linux-kernel - Re: [PATCH v4 0/5] Add support for the ds28ec20 one-wire eeprom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 20 Dec 2023 09:26:14 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: marc.ferland@...il.com
Cc: gregkh@...uxfoundation.org, marc.ferland@...atest.com, 
 jeff.dagenais@...il.com, rdunlap@...radead.org, 
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 0/5] Add support for the ds28ec20 one-wire eeprom


On Mon, 18 Dec 2023 10:02:25 -0500, marc.ferland@...il.com wrote:
> From: Marc Ferland <marc.ferland@...atest.com>
> 
> Hi,
> 
> Here is v4 of my ds2433 driver patch series, see [1] for v3.
> 
> Changes:
> v4: Drop last paragraph from the ds2490 patch commit message
>     (suggested by Krzysztof).
>     Rename the __ds_read_block function to read_block_chunk.
>     Statically allocate the validcrc bitmap, suggested by David
>     Laight.
>     Remove both W1_PAGE_COUNT and W1_F23_TIME defines from the same
>     patch (was previously in separate patches, suggested by
>     Krzysztof).
>     Nullify pointer earlier in w1_f23_remove_slave to better match
>     w1_f23_add_slave (suggested by Krzysztof).
> v3: Do not use in-reply-to when sending a new patch series.
> v2: Incorporate suggestions from Krzysztof Kozlowski: drop the 'w1:
>     ds2433: rename W1_EEPROM_DS2433' and 'w1: ds2433: rename
>     w1_f23_data to w1_data' patches.
>     Create a separate patch for the validcrc bitmap change (also suggested
>     by Krzysztof).
>     Fix build error: initializer element is not a compile-time constant.
>     Rework the ds2490 patch and remove the ds_write_block changes: I
>     have no way of reliably test this change with my current setup,
>     and I did not experience any write failures. Let's not try to fix
>     what already works.
>     Rearrange commit order for a more logical order.
>     Tested with the ds2433 eeprom.
>     Rebased on v6.7-rc2.
> 
> [...]

Applied, thanks!

[1/5] w1: ds2490: support block sizes larger than 128 bytes in ds_read_block
      https://git.kernel.org/krzk/linux-w1/c/d605ba72e9c04efc35fcf225df59d4ccb1d4061f
[2/5] w1: ds2433: remove unused definitions
      https://git.kernel.org/krzk/linux-w1/c/86626c06d651c72bc10c25f263e98fa90655b5ae
[3/5] w1: ds2433: introduce a configuration structure
      https://git.kernel.org/krzk/linux-w1/c/75f0c1c78d709f258004562a540c83bc05bfb962
[4/5] w1: ds2433: use the kernel bitmap implementation
      https://git.kernel.org/krzk/linux-w1/c/3fe3a1bfef75efcdfbcca955fe1d47ec07215110
[5/5] w1: ds2433: add support for ds28ec20 eeprom
      https://git.kernel.org/krzk/linux-w1/c/93c4bb3666a3d463c73a66ab3cc78a4c4b83631a

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>