linux-kernel - Re: [PATCH net-next] wifi: b43legacy: clean up some inconsistent indentings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231220102307.7dd1f187@barney>
Date: Wed, 20 Dec 2023 10:23:07 +0100
From: Michael Büsch <m@...s.ch>
To: Yang Li <yang.lee@...ux.alibaba.com>
Cc: Larry.Finger@...inger.net, kvalo@...nel.org,
 linux-wireless@...r.kernel.org, b43-dev@...ts.infradead.org,
 linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH net-next] wifi: b43legacy: clean up some inconsistent
 indentings

On Wed, 20 Dec 2023 09:12:09 +0800
Yang Li <yang.lee@...ux.alibaba.com> wrote:

> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7783

This link is not publicly accessible.

> a/drivers/net/wireless/broadcom/b43legacy/dma.c +++
> b/drivers/net/wireless/broadcom/b43legacy/dma.c @@ -174,8 +174,8 @@
> static struct b43legacy_dmaring *priority_to_txring( {
>  	struct b43legacy_dmaring *ring;
>  
> -/*FIXME: For now we always run on TX-ring-1 */
> -return dev->dma.tx_ring1;
> +	/*FIXME: For now we always run on TX-ring-1 */
> +	return dev->dma.tx_ring1;
>  
>  	/* 0 = highest priority */
>  	switch (queue_priority) {

Thanks for your patch.

But actually, I am kind of annoyed by the constant stream of whitespace
fixing and dead code removal and other trivial changes to this legacy
driver.

It does not improve the code to add two tabs to this _ancient_ code.

And I can already see the next patch coming that removes the dead code
after this FIXME return. And then the next patch will come to remove
this function altogether, and so on and so on.

This driver has a _lot_ of such code, because it is based on reverse
engineered knowledge with many many unknowns.

IMO this just creates additional maintenance work and pressure on our
maintainers for no good reason.

-- 
Michael Büsch
https://bues.ch/

Content of type "application/pgp-signature" skipped