linux-kernel - Re: [PATCH v2 2/2] interconnect: qcom: Add MSM8909 interconnect provider driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 20 Dec 2023 13:34:33 +0100
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Stephan Gerhold <stephan.gerhold@...nkonzept.com>,
 Georgi Djakov <djakov@...nel.org>
Cc: Bjorn Andersson <andersson@...nel.org>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
 linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Adam Skladowski <a39.skl@...il.com>
Subject: Re: [PATCH v2 2/2] interconnect: qcom: Add MSM8909 interconnect
 provider driver

On 20.12.2023 11:38, Stephan Gerhold wrote:
> From: Adam Skladowski <a39.skl@...il.com>
> 
> Add driver for interconnect busses found in MSM8909 based platforms.
> The topology consists of three NoCs that are partially controlled by
> a RPM processor.
> 
> In the downstream/vendor kernel from Qualcomm there is an additional
> "mm-snoc". However, it actually ends up using the same RPM "snoc_clk"
> as the normal "snoc". It looks like this is actually the same NoC
> in hardware and the "mm-snoc" was only defined to assign a different
> "qcom,util-fact" to increase bandwidth requests by a static margin.
> In mainline we can represent this by assigning the equivalent "ab_coeff"
> to all the nodes that are part of "mm-snoc" downstream.
> 
> Signed-off-by: Adam Skladowski <a39.skl@...il.com>
> [Stephan: Drop separate mm-snoc that exists downstream since it's
>  actually the same NoC as SNoC in hardware, add qos_offset for BIMC,
>  add ab_coeff for mm-snoc nodes and BIMC]
> Signed-off-by: Stephan Gerhold <stephan.gerhold@...nkonzept.com>
> ---
The hard work we put into fixing up smd rpm icc paid off.. thanks!

Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad