linux-kernel - Re: [PATCH v8] ARM: dts: aspeed: Adding Facebook Bletchley BMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <F444BFCC-1D44-4AF6-A0E1-B153A217FFE3@stwcx.xyz>
Date: Wed, 20 Dec 2023 06:38:59 -0600
From: Patrick Williams <patrick@...cx.xyz>
To: Lukas Wunner <lukas@...ner.de>
Cc: Howard Chiu <howard10703049@...il.com>, robh+dt@...nel.org,
 joel@....id.au, andrew@...id.au, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org,
 linux-kernel@...r.kernel.org, potin.lai@...ntatw.com,
 Howard Chiu <howard.chiu@...ntatw.com>
Subject: Re: [PATCH v8] ARM: dts: aspeed: Adding Facebook Bletchley BMC


---
Patrick Williams

> On Dec 20, 2023, at 2:07 AM, Lukas Wunner <lukas@...ner.de> wrote:
> 
> On Tue, Dec 07, 2021 at 05:49:24PM +0800, Howard Chiu wrote:
>> Initial introduction of Facebook Bletchley equipped with
>> Aspeed 2600 BMC SoC.
> [...]
>> +        tpmdev@0 {
>> +            compatible = "tcg,tpm_tis-spi";
> 
> What's the chip used on this board?  Going forward, the DT schema for TPMs
> requires the exact chip name in addition to the generic "tcg,tpm_tis-spi".

Why is this a requirement?  This assumes there is exactly one chip. TPMs are often placed on a pluggable module in which multiple vendors could be used. There is no way in the DTS to specify multiple compatible chips. 

>> +            spi-max-frequency = <33000000>;
>> +            reg = <0>;
>> +        };
>> +    };