linux-kernel - Re: [PATCH vhost v4 02/15] vdpa: Add VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e55c4e1bb1d8dff4943431bab090d541749e9a5.camel@nvidia.com>
Date: Wed, 20 Dec 2023 12:57:19 +0000
From: Dragos Tatulea <dtatulea@...dia.com>
To: "jasowang@...hat.com" <jasowang@...hat.com>
CC: "xuanzhuo@...ux.alibaba.com" <xuanzhuo@...ux.alibaba.com>, Parav Pandit
	<parav@...dia.com>, Gal Pressman <gal@...dia.com>, "eperezma@...hat.com"
	<eperezma@...hat.com>, "virtualization@...ts.linux-foundation.org"
	<virtualization@...ts.linux-foundation.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "si-wei.liu@...cle.com"
	<si-wei.liu@...cle.com>, "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
	"mst@...hat.com" <mst@...hat.com>, Saeed Mahameed <saeedm@...dia.com>,
	"leon@...nel.org" <leon@...nel.org>
Subject: Re: [PATCH vhost v4 02/15] vdpa: Add
 VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag

On Wed, 2023-12-20 at 12:05 +0800, Jason Wang wrote:
> On Wed, Dec 20, 2023 at 11:46 AM Jason Wang <jasowang@...hat.com> wrote:
> > 
> > On Wed, Dec 20, 2023 at 2:09 AM Dragos Tatulea <dtatulea@...dia.com> wrote:
> > > 
> > > The virtio spec doesn't allow changing virtqueue addresses after
> > > DRIVER_OK. Some devices do support this operation when the device is
> > > suspended. The VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag
> > > advertises this support as a backend features.
> > 
> > There's an ongoing effort in virtio spec to introduce the suspend state.
> > 
> > So I wonder if it's better to just allow such behaviour?
> 
> Actually I mean, allow drivers to modify the parameters during suspend
> without a new feature.
> 
Fine by me. Less code is better than more code. The v2 of this series would be
sufficient then.

Thanks