linux-kernel - Re: [PATCH] arm64: dts: qcom: Add coresight nodes for sm8450

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <77ba0140-5b74-40d7-a923-4b270d661d3a@linaro.org>
Date: Wed, 20 Dec 2023 14:21:48 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Jinlong Mao <quic_jinlmao@...cinc.com>, Andy Gross <agross@...nel.org>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konrad.dybcio@...aro.org>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Tingwei Zhang <quic_tingweiz@...cinc.com>,
 Yuanfang Zhang <quic_yuanfang@...cinc.com>,
 Tao Zhang <quic_taozha@...cinc.com>, coresight@...ts.linaro.org
Subject: Re: [PATCH] arm64: dts: qcom: Add coresight nodes for sm8450

On 20/12/2023 14:07, Jinlong Mao wrote:
> 
> 
> On 12/20/2023 8:46 PM, Krzysztof Kozlowski wrote:
>> On 20/12/2023 13:40, Mao Jinlong wrote:
>>> Add coresight components on Qualcomm SM8450 Soc. The components include
>>> TMC ETF/ETR, ETE, STM, TPDM, CTI.
>>>
>>> Signed-off-by: Mao Jinlong <quic_jinlmao@...cinc.com>
>>> ---
>>>   arch/arm64/boot/dts/qcom/sm8450.dtsi | 742 +++++++++++++++++++++++++++
>>>   1 file changed, 742 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>> index 1783fa78bdbc..112b5a069c94 100644
>>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>> @@ -285,6 +285,192 @@ CLUSTER_SLEEP_1: cluster-sleep-1 {
>>>   		};
>>>   	};
>>>   
>>> +	ete0 {
>>
>> ete-0
> Thanks for the review.
> 
> In arm,embedded-trace-extension.yaml, the node name pattern is 
> "^ete([0-9a-f]+)$".

I don't understand why this binding requires ete name. It's not like it
is a generic name worth preserving. Also, the recommended suffix for
names is with '-'.


Best regards,
Krzysztof