linux-kernel - Re: [PATCH 1/2] dt-bindings: iio: adc: ti-ads1298: Add driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231220140039.7b50f874@jic23-huawei>
Date: Wed, 20 Dec 2023 14:00:39 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Mike Looijmans <mike.looijmans@...ic.nl>
Cc: Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 devicetree@...r.kernel.org, linux-iio@...r.kernel.org, Conor Dooley
 <conor+dt@...nel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@...aro.org>, Lars-Peter Clausen <lars@...afoo.de>,
 Rob Herring <robh+dt@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: ti-ads1298: Add driver

> > 
> > Should probably also document the gpios as the binding should attempt to be as complete
> > as possible independent of what the driver currently supports.
> > 
> > Lots of complex options for this device and the use of those pins, so maybe something
> > that can be left for now - but the patch description should then mention that is intentional.  
> 
> The device has so many options for connecting stuff... It's indeed possible to 
> (also) use it as a GPIO expander and as a clock source and more...
> 
> I'll put it in the patch description that the definition is incomplete by design.
> 
> The main reason I'm submitting is that this is about the third time I've 
> written a driver for this chip, and I'm sure that other companies are writing 
> their own as well. I'm hoping this will result in some joint effort to 
> properly support it...
> 

Fair enough. Incomplete bindings aren't ideal, but definitely better than no bindings
in my view.

Jonathan