linux-kernel - Re: [PATCH 1/2] gpiolib: drop tabs from local variable declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZYL1hybEfHxGVQrr@smile.fi.intel.com>
Date: Wed, 20 Dec 2023 16:09:11 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Linus Walleij <linus.walleij@...aro.org>,
	Kent Gibson <warthog618@...il.com>, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH 1/2] gpiolib: drop tabs from local variable declarations

On Tue, Dec 19, 2023 at 08:59:12PM +0100, Bartosz Golaszewski wrote:
> On Tue, Dec 19, 2023 at 4:06 PM Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:
> > On Tue, Dec 19, 2023 at 03:23:22PM +0100, Bartosz Golaszewski wrote:

...

> > > +     struct gpio_chip *gc = desc->gdev->chip;
> > > +     int ret;
> > > +     unsigned long flags;
> > > +     unsigned int offset;
> >
> > I'm wondering if you can make it reversed xmas tree order.
> > This will make it even more consistent between functions.
> 
> Sure but we'd have to update all functions across gpiolib.c. Let's
> take it one thing at a time.

The point is to do this for the lines you modified to avoid additional churn
and burden for backport. At least these two things (removing TABs and shuffling
the order) are kinda of the same family of the logical changes. I do not see
the problem doing this in one patch for the lines you modified. Yet, for the
rest it might be another patch, but I don't think it worth doing it.

-- 
With Best Regards,
Andy Shevchenko