linux-kernel - Re: [PATCH] PCI: Remove unused 'node' member from struct pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87cyv12cbq.fsf@kernel.org>
Date: Wed, 20 Dec 2023 16:11:37 +0200
From: Kalle Valo <kvalo@...nel.org>
To: Mathias Krause <minipli@...ecurity.net>
Cc: Bjorn Helgaas <bhelgaas@...gle.com>,  Arend van Spriel
 <arend.vanspriel@...adcom.com>,  Franky Lin <franky.lin@...adcom.com>,
  Hante Meuleman <hante.meuleman@...adcom.com>,  linux-pci@...r.kernel.org,
  linux-wireless@...r.kernel.org,  linux-kernel@...r.kernel.org,
  SHA-cyfmac-dev-list@...ineon.com,  brcm80211-dev-list.pdl@...adcom.com
Subject: Re: [PATCH] PCI: Remove unused 'node' member from struct pci_driver

Mathias Krause <minipli@...ecurity.net> writes:

> Remove the unused 'node' member. It got replaced by device_driver
> chaining more than 20 years ago in commit 4b4a837f2b57 ("PCI: start to
> use common fields of struct device_driver more...") of the history.git
> tree.
>
> Signed-off-by: Mathias Krause <minipli@...ecurity.net>
> ---
> There is only one "user" that makes use of the 'node' member, which is
> the brcm80211 driver. However, its "use" is clearly wrong (a list head
> cannot be initialized this way) and, obviously, not needed.
>
> If netdev folks instead want to split this off into a separate commit, I
> can do that. However, I don't expect any cross-tree conflicts regarding
> this change.
>
>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 1 -
>  include/linux/pci.h                                     | 2 --
>  2 files changed, 3 deletions(-)

No need to split anything, feel free to take this via PCI tree:

Acked-by: Kalle Valo <kvalo@...nel.org>

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches