linux-kernel - Re: [PATCH v1] sched/rt: Fix rt task's sched latency statistics error in sched_stat_wait trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20231220143249.833273-1-wudaemon@163.com>
Date: Wed, 20 Dec 2023 14:32:49 +0000
From: Junwen Wu <wudaemon@....com>
To: laoar.shao@...il.com
Cc: bristot@...hat.com,
	bsegall@...gle.com,
	dietmar.eggemann@....com,
	juri.lelli@...hat.com,
	linux-kernel@...r.kernel.org,
	mgorman@...e.de,
	mingo@...hat.com,
	peterz@...radead.org,
	rostedt@...dmis.org,
	vincent.guittot@...aro.org,
	vschneid@...hat.com,
	wudaemon@....com
Subject: Re: [PATCH v1] sched/rt: Fix rt task's sched latency statistics error in sched_stat_wait trace_point

>>I think we'd better use if (!on_rt_rq(rt_se))
>>
>> +               update_stats_wait_end_rt(rt_rq, rt_se);
>>
hi, Yafang.when execute update_stats_dequeue_rt, rt_se->on_rq is still 0, util dequeue_rt_stack,
the method is not effect.
I this we can use if (p && p != rq->curr) /*Mark the end of the wait period if dequeueing task*/
because schedstats is not supported for rt group,we only need to update rt_se that is realy task.
--
Best regards