linux-kernel - Re: [PATCH v2 3/5] ASoC: tas2781: Add tas2563 into header file for dsp mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZYRfgCL393O7FEYJ@smile.fi.intel.com>
Date: Thu, 21 Dec 2023 17:53:36 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Shenghao Ding <shenghao-ding@...com>
Cc: broonie@...nel.org, conor+dt@...nel.org, krzysztof.kozlowski@...aro.org,
	robh+dt@...nel.org, kevin-lu@...com, baojun.xu@...com,
	devicetree@...r.kernel.org, lgirdwood@...il.com, perex@...ex.cz,
	pierre-louis.bossart@...ux.intel.com, 13916275206@....com,
	linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
	liam.r.girdwood@...el.com, soyer@....hu, tiwai@...e.de,
	peeyush@...com, navada@...com
Subject: Re: [PATCH v2 3/5] ASoC: tas2781: Add tas2563 into header file for
 dsp mode

On Thu, Dec 21, 2023 at 06:13:43PM +0800, Shenghao Ding wrote:
> Support dsp mode for tas2563.

DSP

...

> +// ALSA SoC Texas Instruments TAS2781/TAS2563 Audio Smart Amplifier

Why not ordered?

...

> +// The TAS2781/TAS2563 driver implements a flexible and configurable

Ditto.

...

> +// TAS2781/TAS2563 chips.

Ditto.

...

>  enum audio_device {
>  	TAS2781	= 0,
> +	TAS2563

Missing comma as this is not a terminator.

>  };

Ditto.

...

I would expect here

enum audio_device {
	TAS2563,
	TAS2781,
};

-- 
With Best Regards,
Andy Shevchenko