linux-kernel - Re: [RFC PATCH 4/7] dt-bindings: reserved-memory: Support osdump module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2c54c808-fa46-48fe-82d4-7628f5c799c5@linaro.org>
Date: Thu, 21 Dec 2023 17:22:24 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Ruipeng Qi <ruipengqi7@...il.com>, robh+dt@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org
Cc: qiruipeng@...iang.com, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 4/7] dt-bindings: reserved-memory: Support osdump
 module

On 21/12/2023 14:31, Ruipeng Qi wrote:
> From: qiruipeng <qiruipeng@...iang.com>
> 
> Add bindings to allow osdump module to store dump in reserved-memory
> region named "osdump".
> 
> Signed-off-by: qiruipeng <qiruipeng@...iang.com>

I have some doubts whether you used your name or just email address as
name...

> ---
>  .../bindings/reserved-memory/osdump.yaml      | 45 +++++++++++++++++++
>  1 file changed, 45 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/reserved-memory/osdump.yaml
> 
> diff --git a/Documentation/devicetree/bindings/reserved-memory/osdump.yaml b/Documentation/devicetree/bindings/reserved-memory/osdump.yaml
> new file mode 100644
> index 000000000000..149bf0204e68
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reserved-memory/osdump.yaml
> @@ -0,0 +1,45 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/reserved-memory/osdump.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: OS minidump module
> +
> +description: |
> +  Specifies that the reserved memory region can be used for OS minidump
> +  module.

I don't see any explanation why this is needed and what you are
describing here. Use simply reserved memory.

If you need any osdump, then work with minidump series. Some time ago we
were asking people to come with their needs. I did not get any other
series, so no clue what you are doing, but just in case:
NAK for second "minidump" clone.


Best regards,
Krzysztof