linux-kernel - [PATCH 0/4] usb: cdns3: usb uvc iso transfer fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20231221165426.1590866-1-Frank.Li@nxp.com>
Date: Thu, 21 Dec 2023 11:54:22 -0500
From: Frank Li <Frank.Li@....com>
To: peter.chen@...nel.org,
	cugyly@....com
Cc: Frank.Li@....com,
	a-govindraju@...com,
	gregkh@...uxfoundation.org,
	imx@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org,
	pawell@...ence.com,
	rogerq@...nel.org
Subject: [PATCH 0/4] usb: cdns3: usb uvc iso transfer fix

Fix UVC ISO transfer since enable sg.

The basic there are 4 major problems.

Problem 1:
	Previous code have not conside sg enable case at all for ISO transfer.
A typcial UVC package is
	UVC Header: 8bytes
	UVC DATA: P(1K,2K... 3K) - 8
     So need prepare two TRB for this TD transfer.
	CHAIN TRB
	DATA TRB.

	Hardware will fetch it when get every SOF regardless IN token. So
driver have to dupicate it to interval.
	for example, if interval is 4.  driver need duplcate 4 times

        [CHIAN TRB] [DATA TRB]
	[CHIAN TRB] [DATA TRB]
	[CHIAN TRB] [DATA TRB]
	[CHIAN TRB] [DATA TRB]

	Hardware have limitation,  LINK have to be first one when
ISO transfer.  another words, the below pattern is *invalidate*
	[CHIAN TRB] [LINK TRB] [DATA TRB]

	So need insert some DUMMY LINK TRB when close to end of TRB list.

Problem 2:
	When mult and wMaxburst is not zero, EP hardware config need match
EP descriptor, otherwise some data will be lost. for example: if mult is 2
at EP descipor, but hardware EP_CFG is 0, only 1 package will be transfer.
If 2k data lost every 3k data.

Problem 3:
	Look like hardware have not fixed cross 4k bound problem at 8QXP
for ISO transfer. If dma buffer + length cross 4k bound,  DMA will fetch
wrong data

Problem 4:
	Latest f_uvc.c pass full speed descriptor, so missed mult and
wMaxBurst information, so cdns3 check_config() have not reserve enough
internal FIFO memory to ISO endponit.

Please more detail for each patches.

Frank Li (4):
  usb: cdns3: fix uvc failure work since sg support enabled
  usb: cdns3: fix iso transfer error when mult is not zero
  usb: cdns3: Fix uvc fail when DMA cross 4k boundery since sg  enabled
  Revert "usb: gadget: f_uvc: change endpoint allocation in
    uvc_function_bind()"

 drivers/usb/cdns3/cdns3-gadget.c    | 142 +++++++++++++++++++++-------
 drivers/usb/cdns3/cdns3-gadget.h    |   3 +
 drivers/usb/gadget/function/f_uvc.c |  10 +-
 3 files changed, 119 insertions(+), 36 deletions(-)

-- 
2.34.1