linux-kernel - Re: [PATCH v2 5/5] ASoC: dt-bindings: Add tas2563 into ti,ta2781.yaml to support dsp mode better

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <40d09489-8242-4be7-bbe1-4e80a729c218@linaro.org>
Date: Thu, 21 Dec 2023 18:29:23 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Shenghao Ding <shenghao-ding@...com>, broonie@...nel.org,
 conor+dt@...nel.org
Cc: robh+dt@...nel.org, andriy.shevchenko@...ux.intel.com, kevin-lu@...com,
 baojun.xu@...com, devicetree@...r.kernel.org, lgirdwood@...il.com,
 perex@...ex.cz, pierre-louis.bossart@...ux.intel.com, 13916275206@....com,
 linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
 liam.r.girdwood@...el.com, soyer@....hu, tiwai@...e.de, peeyush@...com,
 navada@...com
Subject: Re: [PATCH v2 5/5] ASoC: dt-bindings: Add tas2563 into ti,ta2781.yaml
 to support dsp mode better

On 21/12/2023 11:13, Shenghao Ding wrote:
> Add tas2563 to better support dsp mode.
> 
> Signed-off-by: Shenghao Ding <shenghao-ding@...com>
> 
> ---
> Change in v2:
>  - Add devicetree list and other list of necessary people and lists to CC
>  - Express Compatibility in the bindings

Nothing changed in that matter - no compatibility was expressed.

...

>  
> -allOf:
> -  - $ref: dai-common.yaml#
> -
>  properties:
>    compatible:
> +    description: |
> +      ti,tas2781: 24-V Class-D Amplifier with Real Time Integrated Speaker
> +      Protection and Audio Processing, 16/20/24/32bit stereo I2S or
> +      multichannel TDM.
> +
> +      ti,tas2563: 6.1-W Boosted Class-D Audio Amplifier With Integrated
> +      DSP and IV Sense, 16/20/24/32bit stereo I2S or multichannel TDM.
>      enum:
>        - ti,tas2781
> +      - ti,tas2563          # fallback compatible

I don't see any use of fallback. The comment is meaningless. Open
example-schema and see how it is done there.

>  
> -  reg:
> -    description:
> -      I2C address, in multiple tas2781s case, all the i2c address
> -      aggregate as one Audio Device to support multiple audio slots.
> -    maxItems: 8
> -    minItems: 1
> -    items:
> -      minimum: 0x38
> -      maximum: 0x3f
> +  reg: true

No, why? Keep min/maxItems.

>  
>    reset-gpios:
>      maxItems: 1
> @@ -49,6 +46,34 @@ required:
>    - compatible
>    - reg
>  
> +allOf:
> +  - $ref: dai-common.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - ti,tas2781
> +    then:
> +      properties:
> +        reg:
> +          description:
> +            I2C address, in multiple AMP case, all the i2c address
> +            aggregate as one Audio Device to support multiple audio slots.

Description applies to second case as well, so keep it in top-level.



Best regards,
Krzysztof