linux-kernel - Re: [PATCH -next v4 2/2] mm: vmscan: add new event to trace shrink lru

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <65adb1a4-51c5-40f7-b345-f278abb4ef4d@vivo.com>
Date: Thu, 21 Dec 2023 11:16:28 +0800
From: Bixuan Cui <cuibixuan@...o.com>
To: Yu Zhao <yuzhao@...gle.com>
Cc: rostedt@...dmis.org, mhiramat@...nel.org, mathieu.desnoyers@...icios.com,
 akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org, linux-mm@...ck.org,
 opensource.kernel@...o.com
Subject: Re: [PATCH -next v4 2/2] mm: vmscan: add new event to trace shrink
 lru



在 2023/12/21 1:54, Yu Zhao 写道:
>> Signed-off-by: Bixuan Cui<cuibixuan@...o.com>
>> Reviewed-by: Andrew Morton<akpm@...ux-foundation.org>
>> ---
>> v4: Add Reviewed-by and Changlog to every patch.
> Where did Andrew provide his Reviewed-by?Hi,
I just want to add Reviewed-by to my patch to thank the reveiw of Steven 
and Andrew.:-)


> 
>> v2: Modify trace_mm_vmscan_lru_shrink_inactive() in evict_folios() at the same time to fix build error.
> The reason v3 was NAK'ed was not mentioned or fixed in v4.
> 
> So NAK again.
The build error pointed out by Andrew has been fixed in [mm: vmscan: add 
new event to trace shrink lru]:

@@ -4524,9 +4528,10 @@ static int evict_folios(struct lruvec *lruvec, 
struct scan_control *sc, int swap
  	if (list_empty(&list))
  		return scanned;
  retry:
+	trace_mm_vmscan_lru_shrink_inactive_start(pgdat->node_id);
  	reclaimed = shrink_folio_list(&list, pgdat, sc, &stat, false);
  	sc->nr_reclaimed += reclaimed;
-	trace_mm_vmscan_lru_shrink_inactive(pgdat->node_id,
+	trace_mm_vmscan_lru_shrink_inactive_end(pgdat->node_id,
  			scanned, reclaimed, &stat, sc->priority,
  			type ? LRU_INACTIVE_FILE : LRU_INACTIVE_ANON);

Are there any other reasons for NAK? And thank you for your review.


Thanks
Bixuan Cui