linux-kernel - Re: [PATCH mm] kasan: fix for "kasan: rename and document kasan_(un)poison_object

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 21 Dec 2023 21:06:29 +0100
From: Marco Elver <elver@...gle.com>
To: andrey.konovalov@...ux.dev
Cc: Andrew Morton <akpm@...ux-foundation.org>, Andrey Konovalov <andreyknvl@...il.com>, 
	Alexander Potapenko <glider@...gle.com>, Dmitry Vyukov <dvyukov@...gle.com>, 
	Andrey Ryabinin <ryabinin.a.a@...il.com>, kasan-dev@...glegroups.com, linux-mm@...ck.org, 
	linux-kernel@...r.kernel.org, Andrey Konovalov <andreyknvl@...gle.com>
Subject: Re: [PATCH mm] kasan: fix for "kasan: rename and document kasan_(un)poison_object_data"

On Thu, 21 Dec 2023 at 19:06, <andrey.konovalov@...ux.dev> wrote:
>
> From: Andrey Konovalov <andreyknvl@...gle.com>
>
> Update references to renamed functions in comments.
>
> Fixes: ac6b240e1ede ("kasan: rename and document kasan_(un)poison_object_data")
> Signed-off-by: Andrey Konovalov <andreyknvl@...gle.com>

Reviewed-by: Marco Elver <elver@...gle.com>

> ---
>  mm/kasan/shadow.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/kasan/shadow.c b/mm/kasan/shadow.c
> index d687f09a7ae3..0154d200be40 100644
> --- a/mm/kasan/shadow.c
> +++ b/mm/kasan/shadow.c
> @@ -130,7 +130,7 @@ void kasan_poison(const void *addr, size_t size, u8 value, bool init)
>
>         /*
>          * Perform shadow offset calculation based on untagged address, as
> -        * some of the callers (e.g. kasan_poison_object_data) pass tagged
> +        * some of the callers (e.g. kasan_poison_new_object) pass tagged
>          * addresses to this function.
>          */
>         addr = kasan_reset_tag(addr);
> @@ -170,7 +170,7 @@ void kasan_unpoison(const void *addr, size_t size, bool init)
>
>         /*
>          * Perform shadow offset calculation based on untagged address, as
> -        * some of the callers (e.g. kasan_unpoison_object_data) pass tagged
> +        * some of the callers (e.g. kasan_unpoison_new_object) pass tagged
>          * addresses to this function.
>          */
>         addr = kasan_reset_tag(addr);
> --
> 2.25.1
>