linux-kernel - Re: [PATCH 13/52] perf annotate-data: Add dso->data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZYSbzZv-Y-j0_feZ@kernel.org>
Date: Thu, 21 Dec 2023 17:10:53 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Namhyung Kim <namhyung@...nel.org>
Cc: Jiri Olsa <jolsa@...nel.org>, Peter Zijlstra <peterz@...radead.org>,
	Ian Rogers <irogers@...gle.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Ingo Molnar <mingo@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
	linux-perf-users@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Stephane Eranian <eranian@...gle.com>,
	Masami Hiramatsu <mhiramat@...nel.org>,
	Andi Kleen <ak@...ux.intel.com>, linux-trace-devel@...r.kernel.org,
	linux-toolchains@...r.kernel.org
Subject: Re: [PATCH 13/52] perf annotate-data: Add dso->data_types tree

Em Thu, Nov 09, 2023 at 03:59:32PM -0800, Namhyung Kim escreveu:
> +++ b/tools/perf/util/dso.h
> @@ -154,6 +154,8 @@ struct dso {
>  	size_t		 symbol_names_len;
>  	struct rb_root_cached inlined_nodes;
>  	struct rb_root_cached srclines;
> +	struct rb_root	data_types;
> +
>  	struct {
>  		u64		addr;
>  		struct symbol	*symbol;

At some point we need to make these feature specific members to be
associated on demand, maybe thru some hash table, etc.

I.e. the most basic workflow, what everybody needs should be in 'struct
dso', something one _may_ want, like data profiling, should be in
associated with that DSO thru some other way.

I'm applying this now as this is a super cool feature, but think about
it.

- Arnaldo