linux-kernel - Re: [PATCH v2] dmaengine: idxd: Remove usage of the deprecated ida_simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2dd7c5fd-7ecf-6741-1848-1585705d1589@intel.com>
Date: Wed, 20 Dec 2023 19:44:43 -0800
From: Fenghua Yu <fenghua.yu@...el.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>, Dave Jiang
	<dave.jiang@...el.com>, Vinod Koul <vkoul@...nel.org>
CC: <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>,
	<dmaengine@...r.kernel.org>
Subject: Re: [PATCH v2] dmaengine: idxd: Remove usage of the deprecated
 ida_simple_xx() API



On 12/19/23 11:33, Christophe JAILLET wrote:
> ida_alloc() and ida_free() should be preferred to the deprecated
> ida_simple_get() and ida_simple_remove().
> 
> This is less verbose.
> 
> Note that the upper limit of ida_simple_get() is exclusive, but the one of
> ida_alloc_range() is inclusive. Sothis change allows one more device.
> 
> MINORMASK is ((1U << MINORBITS) - 1), so allowing MINORMASK as a maximum value
> makes sense. It is also consistent with other "ida_.*MINORMASK" and
> "ida_*MINOR()" usages.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Reviewed-by: Fenghua Yu <fenghua.yu@...el.com>

Thanks.

-Fenghua