linux-kernel - Re: [PATCH v5 11/16] dt-bindings: imx6q-pcie: Add imx95 pcie compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231221225218.GA232422-robh@kernel.org>
Date: Thu, 21 Dec 2023 16:52:18 -0600
From: Rob Herring <robh@...nel.org>
To: Frank Li <Frank.Li@....com>
Cc: manivannan.sadhasivam@...aro.org, bhelgaas@...gle.com, conor+dt@...nel.org, devicetree@...r.kernel.org, festevam@...il.com, helgaas@...nel.org, hongxing.zhu@....com, imx@...ts.linux.dev, kernel@...gutronix.de, krzysztof.kozlowski+dt@...aro.org, krzysztof.kozlowski@...aro.org, kw@...ux.com, l.stach@...gutronix.de, linux-arm-kernel@...ts.infradead.org, linux-imx@....com, linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org, lpieralisi@...nel.org, s.hauer@...gutronix.de, shawnguo@...nel.org
Subject: Re: [PATCH v5 11/16] dt-bindings: imx6q-pcie: Add imx95 pcie
 compatible string

On Wed, Dec 20, 2023 at 04:36:10PM -0500, Frank Li wrote:
> From: Richard Zhu <hongxing.zhu@....com>
> 
> Add i.MX95 PCIe "fsl,imx95-pcie" compatible string.
> Add "atu" and "app" to reg-names.
> 
> Signed-off-by: Richard Zhu <hongxing.zhu@....com>
> ---
> 
> Notes:
>     Change from v2 to v3
>     - Remove krzy's ACK tag
>     - Add condition check for imx95, which required more reg-names then old
>     platform, so need Krzy review again,
>     
>     Change from v1 to v2
>     - add Krzy's ACK tag
> 
>  .../bindings/pci/fsl,imx6q-pcie-common.yaml    |  1 +
>  .../bindings/pci/fsl,imx6q-pcie.yaml           | 18 ++++++++++++++++++
>  2 files changed, 19 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml
> index a284a27c5e873..1b63089ff0aee 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml
> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml
> @@ -207,6 +207,7 @@ allOf:
>                  - fsl,imx6sx-pcie
>                  - fsl,imx6q-pcie
>                  - fsl,imx6qp-pcie
> +                - fsl,imx95-pcie
>                  - fsl,imx6sx-pcie-ep
>                  - fsl,imx6q-pcie-ep
>                  - fsl,imx6qp-pcie-ep
> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> index f20d4f0e3cb6c..8633c622bd178 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> @@ -29,6 +29,7 @@ properties:
>        - fsl,imx8mq-pcie
>        - fsl,imx8mm-pcie
>        - fsl,imx8mp-pcie
> +      - fsl,imx95-pcie
>  
>    clocks:
>      minItems: 3
> @@ -80,6 +81,22 @@ required:
>  allOf:
>    - $ref: /schemas/pci/snps,dw-pcie.yaml#
>    - $ref: /schemas/pci/fsl,imx6q-pcie-common.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - fsl,imx95-pcie
> +    then:
> +      properties:
> +        reg:
> +          minItems: 4
> +        reg-names:
> +          items:
> +            - const: dbi
> +            - const: atu
> +            - const: app
> +            - const: config

Add new entries to the end. Originally, you had dbi and config. Add ata 
and app on the end.

> +
>    - if:
>        properties:
>          compatible:
> @@ -101,6 +118,7 @@ allOf:
>          compatible:
>            enum:
>              - fsl,imx8mq-pcie
> +            - fsl,imx95-pcie
>      then:
>        properties:
>          clocks:
> -- 
> 2.34.1
>