linux-kernel - Re: [PATCH] mm/damon/vaddr: changed asm-generic/mman-common.h to linux/mman.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 21 Dec 2023 23:49:47 +0000
From: SeongJae Park <sj@...nel.org>
To: Tanzir Hasan <tanzirh@...gle.com>
Cc: SeongJae Park <sj@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	damon@...ts.linux.dev,
	linux-mm@...ck.org,
	linux-kernel@...r.kernel.org,
	Nick Desaulniers <nnn@...gle.com>,
	Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH] mm/damon/vaddr: changed asm-generic/mman-common.h to linux/mman.h

Hi Tanzir,


On Thu, 21 Dec 2023 23:11:01 +0000 Tanzir Hasan <tanzirh@...gle.com> wrote:

> asm-generic/mman-common.h can be replaced by linux/mman.h and the file
> will still build correctly. It is an asm-generic file which should be
> avoided if possible.
> 
> Suggested-by: Al Viro <viro@...iv.linux.org.uk>
> Signed-off-by: Tanzir Hasan <tanzirh@...gle.com>

Thank you for this patch :)

Maybe we could add below Fixes: line?  I guess stable@ is intentionally not
added and that makes sense, but please let me know if you think differently.

Fixes: 6dea8add4d28 ("mm/damon/vaddr: support DAMON-based Operation Schemes")

Other than that, looks good to me.

Reviewed-by: SeongJae Park <sj@...nel.org>


Thanks,
SJ

[...]