linux-kernel - Re: [PATCH v2 1/4] dt-bindings: firmware: xilinx: Describe missing child nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 21 Dec 2023 10:17:24 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Michal Simek <michal.simek@....com>, linux-kernel@...r.kernel.org,
 monstr@...str.eu, michal.simek@...inx.com, git@...inx.com
Cc: Conor Dooley <conor+dt@...nel.org>, Jassi Brar
 <jassisinghbrar@...il.com>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Mark Brown <broonie@...nel.org>,
 Naman Trivedi Manojbhai <naman.trivedimanojbhai@....com>,
 Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
 kishore Manne <nava.kishore.manne@....com>,
 linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 1/4] dt-bindings: firmware: xilinx: Describe missing
 child nodes

On 20/12/2023 11:00, Michal Simek wrote:
> +  gpio:
> +    $ref: /schemas/gpio/xlnx,zynqmp-gpio-modepin.yaml#
> +    description: The gpio node describes connect to PS_MODE pins via firmware
> +      interface.
> +    type: object
> +
> +  pcap:
> +    $ref: /schemas/fpga/xlnx,zynqmp-pcap-fpga.yaml
> +    description: The ZynqMP SoC uses the PCAP (Processor Configuration Port) to
> +      configure the Programmable Logic (PL). The configuration uses the
> +      firmware interface.
> +    type: object
> +
> +  pinctrl:
> +    $ref: /schemas/pinctrl/xlnx,zynqmp-pinctrl.yaml#
> +    description: The pinctrl node provides access to pinconfig and pincontrol
> +      functionality available in firmware.
> +    type: object
> +
> +  power-controller:
> +    $ref: /schemas/power/reset/xlnx,zynqmp-power.yaml#

This should be "power-controller" only if it is a power domain provider.
Is it? Bot's report suggest it is not, therefore I suggested
power-management.

Also, please extend the example. The top-level example for complex
devices should be complete. Apologies for not bringing it earlier.

Best regards,
Krzysztof