linux-kernel - Re: [PATCH] iio: buffer: Use IIO_SEPARATE instead of a hard-coded 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231221104940.7e9d7b0f@jic23-huawei>
Date: Thu, 21 Dec 2023 10:49:40 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Lars-Peter Clausen <lars@...afoo.de>, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org, linux-iio@...r.kernel.org
Subject: Re: [PATCH] iio: buffer: Use IIO_SEPARATE instead of a hard-coded 0

On Sun, 17 Dec 2023 17:41:45 +0100
Christophe JAILLET <christophe.jaillet@...adoo.fr> wrote:

> Use an explicit IIO_SEPARATE instead of 0 for the 'shared_by' parameter
> when calling __iio_add_chan_devattr().
> 
> For some reason, commit 3704432fb1fd ("iio: refactor info mask and ext_info
> attribute creation.") updated only 1 place out of 4.
> Update the remaining ones now.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Makes sense

Applied to the togreg branch of iio.git.

It's fairly unlikely I'll get another pull request out unless the final
6.7 release isn't until after the new year for some reason.

As such, this is probably now 6.9 material

Thanks,

Jonathan

> ---
>  drivers/iio/industrialio-buffer.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c
> index 09c41e9ccf87..b581a7e80566 100644
> --- a/drivers/iio/industrialio-buffer.c
> +++ b/drivers/iio/industrialio-buffer.c
> @@ -616,7 +616,7 @@ static int iio_buffer_add_channel_sysfs(struct iio_dev *indio_dev,
>  				     &iio_show_fixed_type,
>  				     NULL,
>  				     0,
> -				     0,
> +				     IIO_SEPARATE,
>  				     &indio_dev->dev,
>  				     buffer,
>  				     &buffer->buffer_attr_list);
> @@ -629,7 +629,7 @@ static int iio_buffer_add_channel_sysfs(struct iio_dev *indio_dev,
>  					     &iio_scan_el_show,
>  					     &iio_scan_el_store,
>  					     chan->scan_index,
> -					     0,
> +					     IIO_SEPARATE,
>  					     &indio_dev->dev,
>  					     buffer,
>  					     &buffer->buffer_attr_list);
> @@ -639,7 +639,7 @@ static int iio_buffer_add_channel_sysfs(struct iio_dev *indio_dev,
>  					     &iio_scan_el_ts_show,
>  					     &iio_scan_el_ts_store,
>  					     chan->scan_index,
> -					     0,
> +					     IIO_SEPARATE,
>  					     &indio_dev->dev,
>  					     buffer,
>  					     &buffer->buffer_attr_list);