linux-kernel - Re: [PATCH v2 4/4] media: mediatek: vcodec: Only free buffer VA that is not NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d962815b-087d-4851-b6f0-981531149be9@collabora.com>
Date: Thu, 21 Dec 2023 12:43:07 +0100
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Fei Shao <fshao@...omium.org>, Hans Verkuil <hverkuil-cisco@...all.nl>
Cc: Andrew-CT Chen <andrew-ct.chen@...iatek.com>,
 Matthias Brugger <matthias.bgg@...il.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Nicolas Dufresne <nicolas.dufresne@...labora.com>,
 Tiffany Lin <tiffany.lin@...iatek.com>,
 Xiaoyong Lu <xiaoyong.lu@...iatek.com>,
 Yunfei Dong <yunfei.dong@...iatek.com>,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-media@...r.kernel.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v2 4/4] media: mediatek: vcodec: Only free buffer VA that
 is not NULL

Il 21/12/23 10:17, Fei Shao ha scritto:
> In the MediaTek vcodec driver, while mtk_vcodec_mem_free() is mostly
> called only when the buffer to free exists, there are some instances
> that didn't do the check and triggered warnings in practice.
> 
> We believe those checks were forgotten unintentionally. Add the checks
> back to fix the warnings.
> 
> Signed-off-by: Fei Shao <fshao@...omium.org>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>