linux-kernel - Re: [PATCH 08/17] writeback: Factor should_writeback_folio() out of write_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231221122314.GD17956@lst.de>
Date: Thu, 21 Dec 2023 13:23:14 +0100
From: Christoph Hellwig <hch@....de>
To: Jan Kara <jack@...e.cz>
Cc: Christoph Hellwig <hch@....de>, linux-mm@...ck.org,
	"Matthew Wilcox (Oracle)" <willy@...radead.org>,
	Jan Kara <jack@...e.com>, David Howells <dhowells@...hat.com>,
	Brian Foster <bfoster@...hat.com>, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 08/17] writeback: Factor should_writeback_folio() out
 of write_cache_pages()

On Thu, Dec 21, 2023 at 12:22:06PM +0100, Jan Kara wrote:
> > +static bool should_writeback_folio(struct address_space *mapping,
> > +		struct writeback_control *wbc, struct folio *folio)
> > +{
> 
> I'd call this function folio_prepare_writeback() or something like that to
> make it clearer that this function is not only about the decision whether
> we want to write folio or not but we also clear the dirty bit &
> writeprotect the folio in page tables.

Fine with me.  I'll wait for willy to chime in if he has a strong
preference.