linux-kernel - Re: [PATCH v2 2/2] mfd: intel-lpss: Introduce QUIRK_CLOCK_DIVIDER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZYQywQqwMVDkbrQj@smile.fi.intel.com>
Date: Thu, 21 Dec 2023 14:42:41 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Aleksandrs Vinarskis <alex.vinarskis@...il.com>
Cc: hdegoede@...hat.com, lee@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] mfd: intel-lpss: Introduce
 QUIRK_CLOCK_DIVIDER_UNITY for XPS 9530

On Wed, Dec 20, 2023 at 09:56:21PM +0100, Aleksandrs Vinarskis wrote:
> Some devices (eg. Dell XPS 9530, 2023) due to a firmware bug have a
> misconfigured clock divider, which should've been 1:1. This introduces
> quirk which conditionally re-configures the clock divider to 1:1.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

...

> + * Some devices have misconfigured clock divider due to a firmware bug
> + * Set this to force the clock divider to 1:1 ratio

Same comment: Use periods.

-- 
With Best Regards,
Andy Shevchenko