linux-kernel - Re: [PATCH] platform/surface: aggregator: make ssam_bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 21 Dec 2023 14:10:20 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Hans de Goede <hdegoede@...hat.com>
Cc: linux-kernel@...r.kernel.org, Maximilian Luz <luzmaximilian@...il.com>,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH] platform/surface: aggregator: make ssam_bus_type
 constant and static

On Thu, Dec 21, 2023 at 02:03:03PM +0100, Hans de Goede wrote:
> Hi Greg,
> 
> On 12/19/23 18:18, Greg Kroah-Hartman wrote:
> > Now that the driver core can properly handle constant struct bus_type,
> > move the ssam_bus_type variable to be a constant structure as well,
> > placing it into read-only memory which can not be modified at runtime.
> > 
> > It's also never used outside of
> > drivers/platform/surface/aggregator/bus.c so make it static and don't
> > export it as no one is using it.
> > 
> > Cc: Maximilian Luz <luzmaximilian@...il.com>
> > Cc: Hans de Goede <hdegoede@...hat.com>
> > Cc: "Ilpo Järvinen" <ilpo.jarvinen@...ux.intel.com>
> > Cc: platform-driver-x86@...r.kernel.org
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> Greg, do you plan to merge this yourself (fine with me)
> or do you want me to merge this through pdx86 ?

I can merge it, thanks!

greg k-h