linux-kernel - Re: [PATCH 0/3] Fairphone 5 PMIC-GLINK support (USB-C, charger, fuel gauge)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <CXU22OZNAH2H.24YIQWBA4KE3C@fairphone.com>
Date: Thu, 21 Dec 2023 14:45:26 +0100
From: "Luca Weiss" <luca.weiss@...rphone.com>
To: "Konrad Dybcio" <konrad.dybcio@...aro.org>, "Dmitry Baryshkov"
 <dmitry.baryshkov@...aro.org>
Cc: "Bjorn Andersson" <andersson@...nel.org>, "Rob Herring"
 <robh+dt@...nel.org>, "Krzysztof Kozlowski"
 <krzysztof.kozlowski+dt@...aro.org>, "Conor Dooley" <conor+dt@...nel.org>,
 "Heikki Krogerus" <heikki.krogerus@...ux.intel.com>, "Greg Kroah-Hartman"
 <gregkh@...uxfoundation.org>, <cros-qcom-dts-watchers@...omium.org>,
 <~postmarketos/upstreaming@...ts.sr.ht>, <phone-devel@...r.kernel.org>,
 <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <linux-usb@...r.kernel.org>
Subject: Re: [PATCH 0/3] Fairphone 5 PMIC-GLINK support (USB-C, charger,
 fuel gauge)

On Thu Dec 21, 2023 at 1:53 PM CET, Konrad Dybcio wrote:
> On 21.12.2023 11:34, Dmitry Baryshkov wrote:
> > On Thu, 21 Dec 2023 at 09:33, Luca Weiss <luca.weiss@...rphone.com> wrote:
> >>
> >> On Wed Dec 20, 2023 at 1:32 PM CET, Konrad Dybcio wrote:
> >>> On 20.12.2023 11:02, Luca Weiss wrote:
> >>>> This series adds all the necessary bits to enable USB-C role switching,
> >>>> charger and fuel gauge (all via pmic-glink) on Fairphone 5.
> >>>>
> >>>> One thing that could be made different is the pmic-glink compatible.
> >>>> I've chosen to use qcm6490 compatible for it and not sc7280 since
> >>>> there's plenty of firmware variety on sc7280-based platforms and they
> >>>> might require different quirks in the future, so limit this PDOS quirk
> >>>> to just qcm6490 for now.
> >>>>
> >>>> If someone thinks it should be qcom,sc7280-pmic-glink, please let me
> >>>> know :)
> >>> IMO it's best to continue using the "base soc" (which just so happened
> >>> to fall onto sc7280 this time around) for all compatibles, unless the
> >>> derivatives actually had changes
> >>
> >> Hi Konrad,
> >>
> >> I think at some point I asked Dmitry what he thought and he mentioned
> >> qcm6490. Even found the message again:
> >>
> >>> well, since it is a firmware thing, you might want to emphasise that.
> >>> So from my POV qcm6490 makes more sense
> >>
> >> But yeah since it's likely that sc7280 firmware behaves the same as
> >> qcm6490 firmware it's probably okay to use sc7280 compatible, worst case
> >> we change it later :) I'll send a v2 with those changes.
> > 
> > Worst case we end up with sc7280 which has yet another slightly
> > different UCSI / PMIC GLINK implementation, but the compatible string
> > is already taken.
> > I still suppose that this should be a qcm6490-related string.
> Right, let's keep qcm then

Ack from my side also. Thanks for the feedback!

>
> Konrad