linux-kernel - Re: [PATCH V2] arm64: dts: qcom: qcm6490: Add UFS nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 21 Dec 2023 14:58:55 +0100
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Manish Pandey <quic_mapa@...cinc.com>,
 Bjorn Andersson <andersson@...nel.org>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, quic_cang@...cinc.com,
 quic_nguyenb@...cinc.com, quic_nitirawa@...cinc.com,
 quic_bhaskarv@...cinc.com, quic_narepall@...cinc.com,
 quic_rampraka@...cinc.com, quic_ahari@...cinc.com
Subject: Re: [PATCH V2] arm64: dts: qcom: qcm6490: Add UFS nodes

On 21.12.2023 12:19, Manish Pandey wrote:
> Add UFS host controller and Phy nodes for
> Qualcomm qcm6490 Board.
> 
> Signed-off-by: Manish Pandey <quic_mapa@...cinc.com>
> ---
> Changes from v1:
> - updated with correct patchset
Well no, this clearly hasn't been compile-tested..

Please also include the board name in the subject
(qcm6490: -> qcm6490-idp:)
> 
> ---
>  arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> index 03e97e27d16d..51efd46b576c 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> @@ -440,6 +440,25 @@
>  	status = "okay";
>  };
>  
> +&ufs_mem_hc {
> +	reset-gpios = <&tlmm 175 GPIO_ACTIVE_LOW>;
> +	vcc-supply = <&vreg_l7b_2p9>;
> +	vcc-max-microamp = <800000>;
> +	vccq-supply = <&vreg_l9b_1p2>;
> +	vccq-max-microamp = <900000>;
> +	vccq2-supply = <&vreg_l9b_1p2>;
> +	vccq2-max-microamp = <900000>;
These regulators should get regulator-allow-set-load since the
UFS driver expects to perform current/mode setting ops on them

Konrad