linux-kernel - Re: [PATCH v2 02/40] mm/rmap: introduce and use hugetlb_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <06731287-9E14-4623-9280-B9C43E12E021@linux.dev>
Date: Thu, 21 Dec 2023 10:54:30 +0800
From: Muchun Song <muchun.song@...ux.dev>
To: David Hildenbrand <david@...hat.com>
Cc: LKML <linux-kernel@...r.kernel.org>,
 Linux-MM <linux-mm@...ck.org>,
 Andrew Morton <akpm@...ux-foundation.org>,
 "Matthew Wilcox (Oracle)" <willy@...radead.org>,
 Hugh Dickins <hughd@...gle.com>,
 Ryan Roberts <ryan.roberts@....com>,
 Yin Fengwei <fengwei.yin@...el.com>,
 Mike Kravetz <mike.kravetz@...cle.com>,
 Peter Xu <peterx@...hat.com>
Subject: Re: [PATCH v2 02/40] mm/rmap: introduce and use hugetlb_remove_rmap()



> On Dec 21, 2023, at 06:44, David Hildenbrand <david@...hat.com> wrote:
> 
> hugetlb rmap handling differs quite a lot from "ordinary" rmap code.
> For example, hugetlb currently only supports entire mappings, and treats
> any mapping as mapped using a single "logical PTE". Let's move it out
> of the way so we can overhaul our "ordinary" rmap.
> implementation/interface.
> 
> Let's introduce and use hugetlb_remove_rmap() and remove the hugetlb
> code from page_remove_rmap(). This effectively removes one check on the
> small-folio path as well.
> 
> Add sanity checks that we end up with the right folios in the right
> functions.
> 
> Note: all possible candidates that need care are page_remove_rmap() that
>      pass compound=true.
> 
> Reviewed-by: Yin Fengwei <fengwei.yin@...el.com>
> Reviewed-by: Ryan Roberts <ryan.roberts@....com>
> Reviewed-by: Matthew Wilcox (Oracle) <willy@...radead.org>
> Signed-off-by: David Hildenbrand <david@...hat.com>

Reviewed-by: Muchun Song <songmuchun@...edance.com>

Thanks.