linux-kernel - Re: [PATCH RESEND] iio: adc: sun4i-gpadc-iio: adaptation interrupt number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231221152650.GN10102@google.com>
Date: Thu, 21 Dec 2023 15:26:50 +0000
From: Lee Jones <lee@...nel.org>
To: Andre Przywara <andre.przywara@....com>
Cc: fuyao <fuyao1697@....com>, Chen-Yu Tsai <wens@...e.org>,
	Jernej Skrabec <jernej.skrabec@...il.com>,
	Samuel Holland <samuel@...lland.org>,
	linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
	linux-kernel@...r.kernel.org, Maxime Ripard <mripard@...nel.org>,
	maijianzhang <maijianzhang@...winnertech.com>
Subject: Re: [PATCH RESEND] iio: adc: sun4i-gpadc-iio: adaptation interrupt
 number

On Thu, 21 Dec 2023, Lee Jones wrote:

> On Wed, 20 Dec 2023, Andre Przywara wrote:
> 
> > On Wed, 20 Dec 2023 15:23:17 +0800
> > fuyao <fuyao1697@....com> wrote:
> > 
> > Hi,
> > 
> > > __platform_get_irq_byname determinies whether the interrupt
> > > number is 0 and returns EINVAL.
> > 
> > can you please say what this fixes, exactly? Is something not working at
> > the moment? Can you please provide parts of the error message?
> > 
> > And maybe expand the explanation a bit more? For instance mention that the
> > identifiers are used as IRQ resource numbers, where 0 is treated specially.
> > 
> > Cheers,
> > Andre
> > 
> > > 
> > > Signed-off-by: fuyao <fuyao1697@....com>
> 
> You have to use your full real name as well.
> 
> > > Acked-by: Jernej Skrabec <jernej.skrabec@...il.com>
> > > ---
> > >  include/linux/mfd/sun4i-gpadc.h | 4 ++--

Also the subject line is wrong.

This doesn't have anything to do with IIO.

> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/include/linux/mfd/sun4i-gpadc.h b/include/linux/mfd/sun4i-gpadc.h
> > > index ea0ccf33a459..021f820f9d52 100644
> > > --- a/include/linux/mfd/sun4i-gpadc.h
> > > +++ b/include/linux/mfd/sun4i-gpadc.h
> > > @@ -81,8 +81,8 @@
> > >  #define SUN4I_GPADC_TEMP_DATA				0x20
> > >  #define SUN4I_GPADC_DATA				0x24
> > >  
> > > -#define SUN4I_GPADC_IRQ_FIFO_DATA			0
> > > -#define SUN4I_GPADC_IRQ_TEMP_DATA			1
> > > +#define SUN4I_GPADC_IRQ_FIFO_DATA			1
> > > +#define SUN4I_GPADC_IRQ_TEMP_DATA			2
> > >  
> > >  /* 10s delay before suspending the IP */
> > >  #define SUN4I_GPADC_AUTOSUSPEND_DELAY			10000
> > 
> 
> -- 
> Lee Jones [李琼斯]

-- 
Lee Jones [李琼斯]