linux-kernel - Re: [PATCH v2] LoongArch: signal.c: add header file to fix build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 22 Dec 2023 12:59:05 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: linux-kernel@...r.kernel.org, WANG Xuerui <kernel@...0n.name>, 
	loongarch@...ts.linux.dev, Kent Overstreet <kent.overstreet@...il.com>
Subject: Re: [PATCH v2] LoongArch: signal.c: add header file to fix build error

Hi, Randy,

I cannot reproduce it with the default config file.

Huacai

On Fri, Dec 22, 2023 at 12:46 PM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> loongarch's signal.c uses rseq_signal_deliver() so it should
> pull in the appropriate header to prevent a build error:
>
> ../arch/loongarch/kernel/signal.c: In function 'handle_signal':
> ../arch/loongarch/kernel/signal.c:1034:9: error: implicit declaration of function 'rseq_signal_deliver' [-Werror=implicit-function-declaration]
>  1034 |         rseq_signal_deliver(ksig, regs);
>       |         ^~~~~~~~~~~~~~~~~~~
>
> Fixes: b74baf4ad05b ("LoongArch: Add signal handling support")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Huacai Chen <chenhuacai@...nel.org>
> Cc: WANG Xuerui <kernel@...0n.name>
> Cc: loongarch@...ts.linux.dev
> Cc: Kent Overstreet <kent.overstreet@...il.com>
> ---
> v2: repair Cc: list
>
>  arch/loongarch/kernel/signal.c |    1 +
>  1 file changed, 1 insertion(+)
>
> diff -- a/arch/loongarch/kernel/signal.c b/arch/loongarch/kernel/signal.c
> --- a/arch/loongarch/kernel/signal.c
> +++ b/arch/loongarch/kernel/signal.c
> @@ -15,6 +15,7 @@
>  #include <linux/context_tracking.h>
>  #include <linux/entry-common.h>
>  #include <linux/irqflags.h>
> +#include <linux/rseq.h>
>  #include <linux/sched.h>
>  #include <linux/mm.h>
>  #include <linux/personality.h>