linux-kernel - Re: [PATCH v2 1/2] kernel/cgroup: use kernfs_create_dir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2023122207-faceless-despair-af43@gregkh>
Date: Fri, 22 Dec 2023 07:15:17 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Tejun Heo <tj@...nel.org>
Cc: Max Kellermann <max.kellermann@...os.com>,
	Zefan Li <lizefan.x@...edance.com>,
	Johannes Weiner <hannes@...xchg.org>, linux-kernel@...r.kernel.org,
	cgroups@...r.kernel.org
Subject: Re: [PATCH v2 1/2] kernel/cgroup: use kernfs_create_dir_ns()

On Fri, Dec 22, 2023 at 06:29:43AM +0900, Tejun Heo wrote:
> On Fri, Dec 08, 2023 at 10:33:09AM +0100, Max Kellermann wrote:
> > By passing the fsugid to kernfs_create_dir_ns(), we don't need
> > cgroup_kn_set_ugid() any longer.  That function was added for exactly
> > this purpose by commit 49957f8e2a43 ("cgroup: newly created dirs and
> > files should be owned by the creator").
> > 
> > Eliminating this piece of duplicate code means we benefit from future
> > improvements to kernfs_create_dir_ns(); for example, both are lacking
> > S_ISGID support currently, which my next patch will add to
> > kernfs_create_dir_ns().  It cannot (easily) be added to
> > cgroup_kn_set_ugid() because we can't dereference struct kernfs_iattrs
> > from there.
> > 
> > Signed-off-by: Max Kellermann <max.kellermann@...os.com>
> > Acked-by: Tejun Heo <tj@...nel.org>
> 
> Applied to cgroup/for-6.8. Greg, can you please take the second patch?

Both are already in my tree, thanks.

greg k-h