linux-kernel - Re: [PATCH v2] ufs: mcq: Adding a function for MCQ enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <534326e6da3b692648eb0be2be6f88e7957d3d89.camel@mediatek.com>
Date: Fri, 22 Dec 2023 06:31:18 +0000
From: Peter Wang (王信友) <peter.wang@...iatek.com>
To: "ebiggers@...gle.com" <ebiggers@...gle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"quic_nguyenb@...cinc.com" <quic_nguyenb@...cinc.com>, "jejb@...ux.ibm.com"
	<jejb@...ux.ibm.com>, "beanhuo@...ron.com" <beanhuo@...ron.com>,
	"avri.altman@....com" <avri.altman@....com>, "bvanassche@....org"
	<bvanassche@....org>, "cw9316.lee@...sung.com" <cw9316.lee@...sung.com>,
	"martin.petersen@...cle.com" <martin.petersen@...cle.com>,
	"quic_asutoshd@...cinc.com" <quic_asutoshd@...cinc.com>,
	"alim.akhtar@...sung.com" <alim.akhtar@...sung.com>, "chu.stanley@...il.com"
	<chu.stanley@...il.com>, "linux-scsi@...r.kernel.org"
	<linux-scsi@...r.kernel.org>, Powen Kao (高伯文)
	<Powen.Kao@...iatek.com>, "Arthur.Simchaev@....com"
	<Arthur.Simchaev@....com>, "mani@...nel.org" <mani@...nel.org>,
	Stanley Chu (朱原陞) <stanley.chu@...iatek.com>,
	"matthias.bgg@...il.com" <matthias.bgg@...il.com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "quic_cang@...cinc.com"
	<quic_cang@...cinc.com>, "angelogioacchino.delregno@...labora.com"
	<angelogioacchino.delregno@...labora.com>, "yang.lee@...ux.alibaba.com"
	<yang.lee@...ux.alibaba.com>
CC: "jt77.jang@...sung.com" <jt77.jang@...sung.com>, "sh043.lee@...sung.com"
	<sh043.lee@...sung.com>, "grant.jung@...sung.com" <grant.jung@...sung.com>,
	"dh0421.hwang@...sung.com" <dh0421.hwang@...sung.com>
Subject: Re: [PATCH v2] ufs: mcq: Adding a function for MCQ enable

On Thu, 2023-12-21 at 15:56 +0900, Chanwoo Lee wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  From: ChanWoo Lee <cw9316.lee@...sung.com>
> 
> The REG_UFS_MEM_CFG register is too general(broad)
> and it is difficult to know the meaning only with a value of 0x1.
> So far, comments were required.
> 
> Therefore, I have added new functions and defines
> to improve code readability/reusability.
> 
> Signed-off-by: ChanWoo Lee <cw9316.lee@...sung.com>
> 
> * v1->v2:
>    1) Excluding ESI_ENABLE
>    2) Replace with ufshcd_rmwl, BIT()
>    3) Separating hba->mcq_enabled
> ---
> 

Reviewed-by: Peter Wang <peter.wang@...iatek.com>