linux-kernel - Re: [PATCH V2 3/4] riscv: mm: Remove unused TASK_SIZE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJF2gTQSZSWJ7qZQckuALHkcJb8kEGTnb8wJQ9H2wgODkN56Lw@mail.gmail.com>
Date: Fri, 22 Dec 2023 15:16:45 +0800
From: Guo Ren <guoren@...nel.org>
To: Leonardo Bras <leobras@...hat.com>
Cc: linux-kernel@...r.kernel.org, paul.walmsley@...ive.com, palmer@...belt.com, 
	alexghiti@...osinc.com, charlie@...osinc.com, xiao.w.wang@...el.com, 
	david@...hat.com, panqinglin2020@...as.ac.cn, rick.p.edgecombe@...el.com, 
	willy@...radead.org, bjorn@...osinc.com, conor.dooley@...rochip.com, 
	cleger@...osinc.com, linux-riscv@...ts.infradead.org, 
	Guo Ren <guoren@...ux.alibaba.com>
Subject: Re: [PATCH V2 3/4] riscv: mm: Remove unused TASK_SIZE_MIN

On Fri, Dec 22, 2023 at 12:49 PM Leonardo Bras <leobras@...hat.com> wrote:
>
> On Thu, Dec 21, 2023 at 10:47:00AM -0500, guoren@...nel.org wrote:
> > From: Guo Ren <guoren@...ux.alibaba.com>
> >
> > Remove TASK_SIZE_MIN because it's not used anymore.
> >
> > Signed-off-by: Guo Ren <guoren@...ux.alibaba.com>
> > Signed-off-by: Guo Ren <guoren@...nel.org>
> > ---
> >  arch/riscv/include/asm/pgtable.h | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h
> > index 74ffb2178f54..e415582276ec 100644
> > --- a/arch/riscv/include/asm/pgtable.h
> > +++ b/arch/riscv/include/asm/pgtable.h
> > @@ -878,7 +878,6 @@ static inline pte_t pte_swp_clear_exclusive(pte_t pte)
> >   */
> >  #ifdef CONFIG_64BIT
> >  #define TASK_SIZE_64 (PGDIR_SIZE * PTRS_PER_PGD / 2)
> > -#define TASK_SIZE_MIN        (PGDIR_SIZE_L3 * PTRS_PER_PGD / 2)
> >
> >  #ifdef CONFIG_COMPAT
> >  #define TASK_SIZE_32 (_AC(0x80000000, UL))
> > @@ -890,7 +889,6 @@ static inline pte_t pte_swp_clear_exclusive(pte_t pte)
> >
> >  #else
> >  #define TASK_SIZE    FIXADDR_START
> > -#define TASK_SIZE_MIN        TASK_SIZE
> >  #endif
> >
> >  #else /* CONFIG_MMU */
> > --
> > 2.40.1
> >
>
> On torvalds/master:
>
> $git grep TASK_SIZE_MIN
> arch/loongarch/include/asm/processor.h:23:#define TASK_SIZE_MIN TASK_SIZE
> arch/loongarch/include/asm/processor.h:36:#define TASK_SIZE_MIN TASK_SIZE32
> arch/riscv/include/asm/pgtable.h:881:#define TASK_SIZE_MIN      (PGDIR_SIZE_L3 * PTRS_PER_PGD / 2)
> arch/riscv/include/asm/pgtable.h:893:#define TASK_SIZE_MIN      TASK_SIZE
>
> I can only see definitions, without any usage, so agreed on removing them.
>
> FWIW:
> Reviewed-by: Leonardo Bras <leobras@...hat.com>
Thx

>
> I would also send a patch for loongarch, since they are in the same boat :)
Eh... I've sent one yesterday together.

https://lore.kernel.org/loongarch/20231221054624.2208019-1-guoren@kernel.org/

>
> Thanks!
> Leo
>


-- 
Best Regards
 Guo Ren