[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <24110918-5402-4877-a80f-db1228afeaa1@foss.st.com>
Date: Fri, 22 Dec 2023 09:48:38 +0100
From: Raphael Gallais-Pou <raphael.gallais-pou@...s.st.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Laurent Pinchart
<laurent.pinchart@...asonboard.com>,
Neil Armstrong
<neil.armstrong@...aro.org>,
Jessica Zhang <quic_jesszhan@...cinc.com>,
Sam
Ravnborg <sam@...nborg.org>,
Maarten Lankhorst
<maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof
Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley
<conor+dt@...nel.org>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Alexandre
Torgue <alexandre.torgue@...s.st.com>,
Yannick Fertre
<yannick.fertre@...s.st.com>,
Philippe Cornu <philippe.cornu@...s.st.com>,
Philipp Zabel <p.zabel@...gutronix.de>,
Lad Prabhakar
<prabhakar.mahadev-lad.rj@...renesas.com>,
Thierry Reding
<thierry.reding@...il.com>
CC: <dri-devel@...ts.freedesktop.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>,
<linux-stm32@...md-mailman.stormreply.com>,
<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v1 2/8] dt-bindings: display: add dt-bindings for STM32
LVDS device
Hi Krzysztof,
Thanks for your review. I wall send another serie later with those modifications.
Best regards,
Raphaƫl
On 12/21/23 18:27, Krzysztof Kozlowski wrote:
> On 21/12/2023 13:28, Raphael Gallais-Pou wrote:
>> Add dt-binding file for "st,stm32-lvds" compatible.
>>
> A nit, subject: drop second/last, redundant "dt-bindings for". The
> "dt-bindings" prefix is already stating that these are bindings.
>
>> Signed-off-by: Raphael Gallais-Pou <raphael.gallais-pou@...s.st.com>
>> ---
>> .../bindings/display/st,stm32-lvds.yaml | 114 ++++++++++++++++++
>> 1 file changed, 114 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/display/st,stm32-lvds.yaml
>>
> ...
>
>> +properties:
>> + "#clock-cells":
>> + const: 0
>> +
>> + compatible:
>> + const: st,stm32-lvds
> Please put compatible as first.
>
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + clocks:
>> + items:
>> + - description: APB peripheral clock
>> + - description: Reference clock for the internal PLL
>> +
>> + clock-names:
>> + items:
>> + - const: pclk
>> + - const: ref
>> +
>> + resets:
>> + maxItems: 1
>> +
>> + ports:
>> + $ref: /schemas/graph.yaml#/properties/ports
>> +
>> + properties:
>> + port@0:
>> + $ref: /schemas/graph.yaml#/properties/port
>> + description: |
>> + LVDS input port node, connected to the LTDC RGB output port.
>> +
>> + port@1:
>> + $ref: /schemas/graph.yaml#/properties/port
>> + description: |
>> + LVDS output port node, connected to a panel or bridge input port.
> Ports are not required? I would assume it won't work without input and
> output.
>
>> +
>> +required:
>> + - "#clock-cells"
>> + - compatible
>> + - reg
>> + - clocks
>> + - clock-names
>> + - resets
>> + - ports
>> +
>> +unevaluatedProperties: false
> additionalProperties instead... or did I miss some $ref anywhere?
>
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/bus/stm32mp25_sys_bus.h>
>> + #include <dt-bindings/clock/stm32mp25-clks.h>
>> + #include <dt-bindings/reset/stm32mp25-resets.h>
>> +
>> + lvds: lvds@...60000 {
>> + #clock-cells = <0>;
>> + compatible = "st,stm32-lvds";
> compatible is always the first property.
>
>> + reg = <0x48060000 0x2000>;
> put clock-cells here
>
>> + clocks = <&rcc CK_BUS_LVDS>, <&rcc CK_KER_LVDSPHY>;
>> + clock-names = "pclk", "ref";
>> + resets = <&rcc LVDS_R>;
> Best regards,
> Krzysztof
>
Powered by blists - more mailing lists