linux-kernel - Re: [PATCH v5 1/2] leds: trigger: netdev: display only supported link speed attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 22 Dec 2023 10:02:25 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Marek Behún <kabel@...nel.org>
Cc: Christian Marangi <ansuelsmth@...il.com>, Pavel Machek <pavel@....cz>,
	Lee Jones <lee@...nel.org>, Jakub Kicinski <kuba@...nel.org>,
	Daniel Golle <daniel@...rotopia.org>,
	"David S. Miller" <davem@...emloft.net>,
	Li Zetao <lizetao1@...wei.com>, linux-kernel@...r.kernel.org,
	linux-leds@...r.kernel.org
Subject: Re: [PATCH v5 1/2] leds: trigger: netdev: display only supported
 link speed attribute

> I am also wondering if this sysfs ABI could be extended for multi-color
> LEDs.
> 
> For example:
>   echo green >link_1000
>   echo yellow >link_100
> 
> Or something like that. But that is a completely different discussion.

I've not looked at how the LED core code supports this.

You do see bi-colour LEDs. They are basically two LEDs head to
tail. You positively bias them and they are one colour, you negatively
bias them and they are a second colour. The two colours are mutually
exclusive.

It is also possible to have two LEDs co-located. That should already
supported, since you can control each LED independently.

It would be good to describe your hardware. We can then figure out how
they LED subsystem should support it.

     Andrew