linux-kernel - Re: [PATCH 4/4] ASoC: codecs: wsa884x: Allow sharing reset GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <444e2faa-4bf1-4a1b-a6dd-ddbf998237e3@linaro.org>
Date: Fri, 22 Dec 2023 16:22:32 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konrad.dybcio@...aro.org>,
 Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
 Banajit Goswami <bgoswami@...cinc.com>, Liam Girdwood <lgirdwood@...il.com>,
 Mark Brown <broonie@...nel.org>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Philipp Zabel <p.zabel@...gutronix.de>,
 Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
 linux-arm-msm@...r.kernel.org, alsa-devel@...a-project.org,
 linux-sound@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: Bartosz Golaszewski <brgl@...ev.pl>,
 Sean Anderson <sean.anderson@...o.com>
Subject: Re: [PATCH 4/4] ASoC: codecs: wsa884x: Allow sharing reset GPIO

On 22/12/2023 16:01, Krzysztof Kozlowski wrote:
>  
> +static int wsa884x_get_reset(struct device *dev, struct wsa884x_priv *wsa884x)
> +{
> +	wsa884x->sd_reset = devm_reset_control_get_optional_shared(dev, NULL);
> +	if (IS_ERR(wsa884x->sd_reset))
> +		return dev_err_probe(dev, PTR_ERR(wsa884x->sd_reset),
> +				     "Failed to get reset\n");
> +

When cleaning up the patchset I removed one piece too much. I should
have here:

if (wsa884x->sd_reset)
	return 0;


Best regards,
Krzysztof