linux-kernel - Re: [PATCH] scripts/kernel-doc: restore warning for Excess struct/union

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87wmt56bfe.fsf@meer.lwn.net>
Date: Fri, 22 Dec 2023 16:54:13 -0700
From: Jonathan Corbet <corbet@....net>
To: Randy Dunlap <rdunlap@...radead.org>, Vegard Nossum
 <vegard.nossum@...cle.com>, linux-kernel@...r.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@...pensource.com>, linux-doc@...r.kernel.org
Subject: Re: [PATCH] scripts/kernel-doc: restore warning for Excess
 struct/union

Randy Dunlap <rdunlap@...radead.org> writes:

> On 12/21/23 07:20, Jonathan Corbet wrote:
>> Vegard Nossum <vegard.nossum@...cle.com> writes:
>> 
>>> On 15/12/2023 17:28, Jonathan Corbet wrote:
>>>> *sigh*
>>>>
>>>> This adds nearly 600 new warnings.  Anybody gonna help fix them?
>>>
>>> I think in the vast majority of the cases the fix will be to just remove
>>> the offending line from the kerneldoc, so it's not particularly
>>> difficult, mostly just overhead from the patch preparation/submission
>>> process.
>>>
>>> I'd be happy to take a stab at it -- I think we could even script most
>>> of it. Respond here, I guess, if anybody else wants to do some so we can
>>> split it up.
>> 
>> It's mostly done; I've gotten it down to under 200 and sent patches to
>> make the changes.  Randy is working on it too, I know.  It's not always
>> just deletion, but the fixes are usually pretty straightforward.
>> 
>
> I'm still seeing lots of Excess warnings from
>   include/crypto/hash.h
>   include/crypto/skcipher.h
>   drivers/gpu/drm/*  (several files there have warnings)
>
> I would be happy to see Vegard's help on this - unless Jon has already
> addressed those warnings.

Nope, I've not gone there and won't manage it before sometime next week
at best.  I'd be delighted if somebody waded into those warnings.

Thanks,

jon