linux-kernel - [PATCH 0/8] Intel PMC Core GBE LTR regression fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20231223032548.1680738-1-david.e.box@linux.intel.com>
Date: Fri, 22 Dec 2023 19:25:40 -0800
From: "David E. Box" <david.e.box@...ux.intel.com>
To: david.e.box@...ux.intel.com,
	hdegoede@...hat.com,
	ilpo.jarvinen@...ux.intel.com,
	rajvi.jingar@...ux.intel.com,
	platform-driver-x86@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH 0/8] Intel PMC Core GBE LTR regression fix

This patch series addresses the network performance regression caused by
commit 804951203aa5 ("platform/x86:intel/pmc: Combine core_init() and
core_configure()").

Unfortunately, the regression is included in the recent Lunar Lake and
Arrow Lake support patches in the review branch. Patches 1 and 2 remove the
LTR ignore without a fix. They may be folded into the respective enabling
patches indicated in the changelog. This is done so that the next patches
fixing the regression can be backported to stable kernels with fewer, if
any, conflicts.

Patches 3 and 4 provide the support needed for Patch 5 to move the GBE LTR
ignore from probe-time to suspend/resume time. All three carry the same
Fixes tag so that the stable kernels can pick them up without causing a
separate suspend-time PC10 regression.

Patches 6 and 7 then add the LTR suspend/resume fix for Arrow Lake and
Lunar Lake. Of course, they cannot be folded into the enabling patches
unless the LTR fixes (3-5) are applied before. Sorry about this :(.

Patch 8 finally addresses an unrelated sparse warning for a missing extern
introduced in the commit mentioned in that changelog. This could be folded
back into that commit if desired.

Note that there is no current solution to address the loss of runtime PC10
with these patches. With a network cable attached to the PCH LAN, the best
that can be achieved is PC8/9. However, this is unlikely to affect many
mobile systems which tend not to use LAN and if they do, not the PCH LAN.

David E. Box (8):
  platform/x86/intel/pmc/arl.c: Remove probe time LTR ignore
  platform/x86/intel/pmc/lnl.c: Remove probe time LTR ignore
  platform/x86/intel/pmc: Add suspend callback
  platform/x86/intel/pmc: Allow renabling LTRs
  platform/x86/intel/pmc: Move GBE LTR ignore to suspend callback
  platform/x86/intel/pmc/arl: Add GBE LTR ignore during suspend
  platform/x86/intel/pmc/lnl: Add GBE LTR ignore during suspend
  platform/x86/intel/pmc: Add missing extern

 drivers/platform/x86/intel/pmc/adl.c  |  9 +++------
 drivers/platform/x86/intel/pmc/arl.c  |  9 +++------
 drivers/platform/x86/intel/pmc/cnp.c  | 26 ++++++++++++++++++++------
 drivers/platform/x86/intel/pmc/core.c | 12 +++++++++---
 drivers/platform/x86/intel/pmc/core.h |  9 ++++++++-
 drivers/platform/x86/intel/pmc/lnl.c  |  9 +++------
 drivers/platform/x86/intel/pmc/mtl.c  |  9 +++------
 drivers/platform/x86/intel/pmc/tgl.c  |  8 +++-----
 8 files changed, 52 insertions(+), 39 deletions(-)

base-commit: 119652b855e6c96676406ee9a7f535f4db4e8eff
-- 
2.34.1