linux-kernel - Re: [PATCH] sched: Fix tg->load when offlining a CPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 23 Dec 2023 15:04:54 +0800
From: kernel test robot <lkp@...el.com>
To: Vincent Guittot <vincent.guittot@...aro.org>, mingo@...hat.com,
	peterz@...radead.org, juri.lelli@...hat.com,
	dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com,
	mgorman@...e.de, bristot@...hat.com, vschneid@...hat.com,
	imran.f.khan@...cle.com, aaron.lu@...el.com,
	linux-kernel@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev,
	Vincent Guittot <vincent.guittot@...aro.org>
Subject: Re: [PATCH] sched: Fix tg->load when offlining a CPU

Hi Vincent,

kernel test robot noticed the following build errors:

[auto build test ERROR on tip/sched/core]
[also build test ERROR on peterz-queue/sched/core linus/master v6.7-rc6 next-20231222]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Vincent-Guittot/sched-Fix-tg-load-when-offlining-a-CPU/20231222-172438
base:   tip/sched/core
patch link:    https://lore.kernel.org/r/20231221164014.447122-1-vincent.guittot%40linaro.org
patch subject: [PATCH] sched: Fix tg->load when offlining a CPU
config: arc-defconfig (https://download.01.org/0day-ci/archive/20231223/202312231446.A3g5SiOr-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231223/202312231446.A3g5SiOr-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312231446.A3g5SiOr-lkp@intel.com/

All errors (new ones prefixed by >>):

   kernel/sched/fair.c: In function 'rq_offline_fair':
>> kernel/sched/fair.c:12498:9: error: implicit declaration of function 'clear_tg_offline_cfs_rqs'; did you mean 'unthrottle_offline_cfs_rqs'? [-Werror=implicit-function-declaration]
   12498 |         clear_tg_offline_cfs_rqs(rq);
         |         ^~~~~~~~~~~~~~~~~~~~~~~~
         |         unthrottle_offline_cfs_rqs
   kernel/sched/fair.c: At top level:
   kernel/sched/fair.c:13124:6: warning: no previous prototype for 'free_fair_sched_group' [-Wmissing-prototypes]
   13124 | void free_fair_sched_group(struct task_group *tg) { }
         |      ^~~~~~~~~~~~~~~~~~~~~
   kernel/sched/fair.c:13126:5: warning: no previous prototype for 'alloc_fair_sched_group' [-Wmissing-prototypes]
   13126 | int alloc_fair_sched_group(struct task_group *tg, struct task_group *parent)
         |     ^~~~~~~~~~~~~~~~~~~~~~
   kernel/sched/fair.c:13131:6: warning: no previous prototype for 'online_fair_sched_group' [-Wmissing-prototypes]
   13131 | void online_fair_sched_group(struct task_group *tg) { }
         |      ^~~~~~~~~~~~~~~~~~~~~~~
   kernel/sched/fair.c:13133:6: warning: no previous prototype for 'unregister_fair_sched_group' [-Wmissing-prototypes]
   13133 | void unregister_fair_sched_group(struct task_group *tg) { }
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +12498 kernel/sched/fair.c

 12489	
 12490	static void rq_offline_fair(struct rq *rq)
 12491	{
 12492		update_sysctl();
 12493	
 12494		/* Ensure any throttled groups are reachable by pick_next_task */
 12495		unthrottle_offline_cfs_rqs(rq);
 12496	
 12497		/* Ensure that we remove rq contribution to group share */
 12498		clear_tg_offline_cfs_rqs(rq);
 12499	}
 12500	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki