linux-kernel - Re: [PATCH 2/3] mm, lru_gen: move pages in bulk when aging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202312231555.KTX84YjF-lkp@intel.com>
Date: Sat, 23 Dec 2023 15:36:37 +0800
From: kernel test robot <lkp@...el.com>
To: Kairui Song <ryncsn@...il.com>, linux-mm@...ck.org
Cc: oe-kbuild-all@...ts.linux.dev,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Memory Management List <linux-mm@...ck.org>,
	Yu Zhao <yuzhao@...gle.com>, linux-kernel@...r.kernel.org,
	Kairui Song <kasong@...cent.com>
Subject: Re: [PATCH 2/3] mm, lru_gen: move pages in bulk when aging

Hi Kairui,

kernel test robot noticed the following build warnings:

[auto build test WARNING on akpm-mm/mm-everything]

url:    https://github.com/intel-lab-lkp/linux/commits/Kairui-Song/mm-lru_gen-batch-update-counters-on-againg/20231222-184601
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20231222102255.56993-3-ryncsn%40gmail.com
patch subject: [PATCH 2/3] mm, lru_gen: move pages in bulk when aging
config: arc-randconfig-002-20231223 (https://download.01.org/0day-ci/archive/20231223/202312231555.KTX84YjF-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231223/202312231555.KTX84YjF-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312231555.KTX84YjF-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> mm/vmscan.c:3108:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
    3108 | static void inline lru_gen_inc_bulk_finish(struct lru_gen_folio *lrugen,
         | ^~~~~~
   mm/vmscan.c:3127:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
    3127 | static void inline lru_gen_try_inc_bulk(struct lru_gen_folio *lrugen, struct folio *folio,
         | ^~~~~~


vim +/inline +3108 mm/vmscan.c

  3107	
> 3108	static void inline lru_gen_inc_bulk_finish(struct lru_gen_folio *lrugen,
  3109						   int bulk_gen, bool type, int zone,
  3110						   struct gen_update_batch *batch)
  3111	{
  3112		if (!batch->head)
  3113			return;
  3114	
  3115		list_bulk_move_tail(&lrugen->folios[bulk_gen][type][zone],
  3116				    &batch->head->lru,
  3117				    &batch->tail->lru);
  3118	
  3119		batch->head = NULL;
  3120	}
  3121	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki