linux-kernel - Re: [PATCH v6 08/40] soc: Add SoC driver for Cirrus ep93xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <04af87cb-1a37-4ce5-8a02-1ae909b0d9eb@app.fastmail.com>
Date: Sat, 23 Dec 2023 11:32:02 +0000
From: "Arnd Bergmann" <arnd@...db.de>
To: "Nikita Shubin" <nikita.shubin@...uefel.me>,
 "Andy Shevchenko" <andriy.shevchenko@...el.com>
Cc: "Conor.Dooley" <conor.dooley@...rochip.com>,
 "Ulf Hansson" <ulf.hansson@...aro.org>, "Joel Stanley" <joel@....id.au>,
 "Walker Chen" <walker.chen@...rfivetech.com>,
 Jonathan Neuschäfer <j.neuschaefer@....net>,
 "Huisong Li" <lihuisong@...wei.com>, "Wei Xu" <xuwei5@...ilicon.com>,
 "Emil Renner Berthing" <kernel@...il.dk>,
 "Linus Walleij" <linus.walleij@...aro.org>,
 "Alexander Sverdlin" <alexander.sverdlin@...il.com>,
 "Hal Feng" <hal.feng@...rfivetech.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 08/40] soc: Add SoC driver for Cirrus ep93xx

On Sat, Dec 23, 2023, at 10:06, Nikita Shubin wrote:
> On Wed, 2023-12-13 at 20:37 +0200, Andy Shevchenko wrote:
>> On Tue, Dec 12, 2023 at 11:20:25AM +0300, Nikita Shubin wrote:

>> 
>> Maybe
>> 
>>         strict device *dev = &pdev->dev;
>>         enum ep93xx_soc_model model;
>>         ...
>>         model = (enum
>> ep93xx_soc_model)(uintptr_t)device_get_match_data(dev);
>> 
>> ?

You can just skip the second cast:

    model = (uintptr_t)device_get_match_data(dev);


or even better, since the only thing you look up by model is the
string put the string directly into the data:

+static const struct of_device_id ep9301_syscon_of_device_ids[] = {
+	{ .compatible	= "cirrus,ep9301-syscon", .data = "pinctrl-ep9301" },
+	{ .compatible	= "cirrus,ep9302-syscon", .data = "pinctrl-ep9301" },
+	{ .compatible	= "cirrus,ep9307-syscon", .data = "pinctrl-ep9307" },
+	{ .compatible	= "cirrus,ep9312-syscon", .data = "pinctrl-ep9312" },
+	{ .compatible	= "cirrus,ep9315-syscon", .data = "pinctrl-ep9312" },
+	{ /* sentinel */ }
+};

Since the strings are constants, gcc should even be able to deduplicate them.

>> 
>> > +       dev_info(dev, "EP93xx SoC revision %s\n", attrs->revision);
>> 
>> Hmm... Is this message anyhow useful?
>> 
>
> Can we keep it please ? It makes us happy when we see it in logs for
> historical reasons - it's been there since 2.4.

In general we don't do these at all, but since you are likely the only
person paying attention to this particular one, you may as well keep it.

     Arnd