linux-kernel - Re: [PATCH v2] staging: media: atomisp: pci: Fix spelling mistake in ia_css_acc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEKBCKPA0-VKA_r+YsGVb0cTKEQpV0dXwU8ARZ07LGmWuH2_OQ@mail.gmail.com>
Date: Sat, 23 Dec 2023 19:44:07 +0545
From: Dipendra Khadka <kdipendra88@...il.com>
To: Hans de Goede <hdegoede@...hat.com>
Cc: Randy Dunlap <rdunlap@...radead.org>, mchehab@...nel.org, sakari.ailus@...ux.intel.com, 
	gregkh@...uxfoundation.org, hpa@...hat.com, linux-media@...r.kernel.org, 
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org, 
	linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH v2] staging: media: atomisp: pci: Fix spelling mistake in ia_css_acc_types.h

Hi,

On Sat, 23 Dec 2023 at 16:10, Hans de Goede <hdegoede@...hat.com> wrote:
>
> Hi,
>
> On 12/23/23 06:18, Randy Dunlap wrote:
> > Hi Dipendra,
> >
> > On 12/22/23 21:11, Dipendra Khadka wrote:
> >> codespell reported spelling mistakes in
> >> ia_css_acc_types.h as below:
> >>
> >> '''
> >> ia_css_acc_types.h:87: cummulative ==> cumulative
> >> ia_css_acc_types.h:411: descibes ==> describes
> >> '''
> >>
> >> This patch fixes these spelling mistakes.
> >>
> >> Signed-off-by: Dipendra Khadka <kdipendra88@...il.com>
> >
> > This patch is an improvement so it could be merged as is IMO.
> > But...
> >
> >> ---
> >> v2:
> >>  - Previously only corrected spelling  mistake reported by checkpatch.pl.
> >>  - All spelling mistakes reported by codespell are fixed.
> >> v1: https://lore.kernel.org/lkml/20231222200350.2024-1-kdipendra88@gmail.com/
> >>
> >>  drivers/staging/media/atomisp/pci/ia_css_acc_types.h | 4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/staging/media/atomisp/pci/ia_css_acc_types.h b/drivers/staging/media/atomisp/pci/ia_css_acc_types.h
> >> index d6e52b4971d6..1dc2085ecd61 100644
> >> --- a/drivers/staging/media/atomisp/pci/ia_css_acc_types.h
> >> +++ b/drivers/staging/media/atomisp/pci/ia_css_acc_types.h
> >> @@ -84,7 +84,7 @@ struct ia_css_blob_info {
> >>              memory_offsets;  /** offset wrt hdr in bytes */
> >>      u32 prog_name_offset;  /** offset wrt hdr in bytes */
> >>      u32 size;                       /** Size of blob */
> >> -    u32 padding_size;       /** total cummulative of bytes added due to section alignment */
> >> +    u32 padding_size;       /** total cumulative of bytes added due to section alignment */
> >
> > I apologize for not looking at your v1 patch carefully.
> > The comment above would be much better as
> >
> >                               /** total accumulation of bytes added due to section alignment */
>
> I agree that that is better. Dipendra can you please send a v3
> using the new text suggested by Randy ?

Sure,let me send a v3 with the new text suggested by Randy.

Regards,

Dipendra

>
> Regards,
>
> Hans
>
>
>
> >>      u32 icache_source;      /** Position of icache in blob */
> >>      u32 icache_size;        /** Size of icache section */
> >>      u32 icache_padding;/** bytes added due to icache section alignment */
> >> @@ -408,7 +408,7 @@ struct ia_css_acc_sp {
> >>  };
> >>
> >>  /* Acceleration firmware descriptor.
> >> -  * This descriptor descibes either SP code (stand-alone), or
> >> +  * This descriptor describes either SP code (stand-alone), or
> >>    * ISP code (a separate pipeline stage).
> >>    */
> >>  struct ia_css_acc_fw_hdr {
> >
>