| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZYbouFFFmf7PInOk@mecka.net>
Date: Sat, 23 Dec 2023 15:03:36 +0100
From: Manuel Traut <manut@...ka.net>
To: Diederik de Haas <didi.debian@...ow.org>
Cc: Neil Armstrong <neil.armstrong@...aro.org>,
Jessica Zhang <quic_jesszhan@...cinc.com>,
Sam Ravnborg <sam@...nborg.org>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Heiko Stuebner <heiko@...ech.de>, Sandy Huang <hjc@...k-chips.com>,
Mark Yao <markyao0591@...il.com>,
Segfault <awarnecke002@...mail.com>,
Arnaud Ferraris <aferraris@...ian.org>,
Danct12 <danct12@...root.org>, dri-devel@...ts.freedesktop.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH 4/6] arm64: dts: rockchip: Add devicetree for Pine64
Pinetab2
On Fri, Dec 22, 2023 at 05:49:35PM +0100, Diederik de Haas wrote:
> On Friday, 22 December 2023 12:05:44 CET Manuel Traut wrote:
> > + rk817-sound {
> > + compatible = "simple-audio-card";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&hp_det_l>;
> > + simple-audio-card,format = "i2s";
> > + simple-audio-card,name = "PineTab2";
> > + simple-audio-card,mclk-fs = <256>;
> > +
> > + simple-audio-card,widgets =
> > + "Microphone", "Mic Jack",
> > + "Headphone", "Headphones",
> > + "Microphone", "Microphone",
> > + "Speaker", "Speakers";
> > +
> > + simple-audio-card,routing =
> > + "MICL", "Microphone",
> > + "MICR", "Mic Jack",
> > + "Headphones", "HPOL",
> > + "Headphones", "HPOR",
> > + "Speaker Amplifier INL", "HPOL",
> > + "Speaker Amplifier INR", "HPOR",
> > + "Speakers", "Speaker Amplifier OUTL",
> > + "Speakers", "Speaker Amplifier OUTR";
> > +
> > + simple-audio-card,hp-det-gpio = <&gpio4 RK_PC6
> > GPIO_ACTIVE_HIGH>; + simple-audio-card,aux-devs =
> > <&speaker_amp>;
> > + simple-audio-card,pin-switches = "Speakers", "Microphone";
> > +
> > + simple-audio-card,cpu {
> > + sound-dai = <&i2s1_8ch>;
> > + };
> > +
> > + simple-audio-card,codec {
> > + sound-dai = <&rk817>;
> > + };
> > + };
>
> Not sure if it's right (or allowed) to post a different patch as attachment,
> but I have been using a different audio configuration (see attachment).
> I haven't yet tried if/how it works via HDMI yet, but the speakers and
> headphones work fine.
> This patch is based on the following commit:
> https://github.com/TuxThePenguin0/linux/commit/
> 872b829a3511cfa853bd3af3bd4f30be1cb3d1ab
Yes, this fixes the headphone detection. I cannot test HDMI because of a missing
cable.
I will pick the change in v2.
> I've added 'Danct12' to the To list as they are the maintainer of the primary
> PT2 image and we worked together to get to this audio config.
> I don't if they still use it.
> (I've been using my own kernel/image for a while now).
Thanks. I just crossed this repo:
https://github.com/dreemurrs-embedded/linux-pinetab2/tree/v6.6.7-danctnix1
It includes some more improvements I will pick for v2.
Regards
Manuel
> From 17efeb0ae766886345ff0574c534079742539b56 Mon Sep 17 00:00:00 2001
> From: Scott Santucci <ScottFreeCode@...rs.noreply.github.com>
> Date: Mon, 17 Jul 2023 13:06:20 +0200
> Subject: [PATCH 3/8] arm64: dts: rk3566-pinetab2: Fix audio configuration
>
> The audio configuration of the PineTab2 matches the `rk817_ext` alsa
> ucm2 profile, so switch the configuration to that. Use `rk817_ext` and
> not `rk817_int` as the PineTab2 uses an external amplifier.
>
> Also the headphones plugged/unplugged detection is backwards, so apply
> the fix provided by Danct12 <danct12@...root.org>.
>
> Signed-off-by: Diederik de Haas <didi.debian@...ow.org>
> Link: https://github.com/dreemurrs-embedded/Pine64-Arch/pull/555
> ---
> arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
> index a766f21bd6f8..59e4bf2f77c7 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
> @@ -116,14 +116,14 @@ rk817-sound {
> pinctrl-names = "default";
> pinctrl-0 = <&hp_det_l>;
> simple-audio-card,format = "i2s";
> - simple-audio-card,name = "PineTab2";
> + simple-audio-card,name = "rk817_ext";
> simple-audio-card,mclk-fs = <256>;
>
> simple-audio-card,widgets =
> "Microphone", "Mic Jack",
> "Headphone", "Headphones",
> "Microphone", "Microphone",
> - "Speaker", "Speakers";
> + "Speaker", "Internal Speakers";
>
> simple-audio-card,routing =
> "MICL", "Microphone",
> @@ -132,12 +132,12 @@ rk817-sound {
> "Headphones", "HPOR",
> "Speaker Amplifier INL", "HPOL",
> "Speaker Amplifier INR", "HPOR",
> - "Speakers", "Speaker Amplifier OUTL",
> - "Speakers", "Speaker Amplifier OUTR";
> + "Internal Speakers", "Speaker Amplifier OUTL",
> + "Internal Speakers", "Speaker Amplifier OUTR";
>
> - simple-audio-card,hp-det-gpio = <&gpio4 RK_PC6 GPIO_ACTIVE_HIGH>;
> + simple-audio-card,hp-det-gpio = <&gpio4 RK_PC6 GPIO_ACTIVE_LOW>;
> simple-audio-card,aux-devs = <&speaker_amp>;
> - simple-audio-card,pin-switches = "Speakers", "Microphone";
> + simple-audio-card,pin-switches = "Internal Speakers", "Microphone";
>
> simple-audio-card,cpu {
> sound-dai = <&i2s1_8ch>;
> --
> 2.42.0
>
Powered by blists - more mailing lists