linux-kernel - Re: [PATCH v5 10/16] dt-bindings: imx6q-pcie: remove reg and reg-name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 23 Dec 2023 23:34:03 -0500
From: Frank Li <Frank.li@....com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Rob Herring <robh@...nel.org>, manivannan.sadhasivam@...aro.org,
	bhelgaas@...gle.com, conor+dt@...nel.org,
	devicetree@...r.kernel.org, festevam@...il.com, helgaas@...nel.org,
	hongxing.zhu@....com, imx@...ts.linux.dev, kernel@...gutronix.de,
	krzysztof.kozlowski+dt@...aro.org, kw@...ux.com,
	l.stach@...gutronix.de, linux-arm-kernel@...ts.infradead.org,
	linux-imx@....com, linux-kernel@...r.kernel.org,
	linux-pci@...r.kernel.org, lpieralisi@...nel.org,
	s.hauer@...gutronix.de, shawnguo@...nel.org
Subject: Re: [PATCH v5 10/16] dt-bindings: imx6q-pcie: remove reg and reg-name

On Sat, Dec 23, 2023 at 07:43:01PM +0100, Krzysztof Kozlowski wrote:
> On 23/12/2023 04:46, Frank Li wrote:
> > On Thu, Dec 21, 2023 at 04:50:33PM -0600, Rob Herring wrote:
> >> On Wed, Dec 20, 2023 at 04:36:09PM -0500, Frank Li wrote:
> >>> snps,dw-pcie.yaml already have reg and reg-name information. Needn't
> >>> duplciate here.
> >>>
> >>> Acked-by: Rob Herring <robh@...nel.org>
> >>> Signed-off-by: Frank Li <Frank.Li@....com>
> >>> ---
> >>>
> >>> Notes:
> >>>     Change from v4 to v5
> >>>     - add Rob's Acked
> >>
> >> Err, that was intended for patch 9, not this one. This patch should be 
> >> dropped.
> > 
> > Sorry, will correct it.
> > 
> > Actually I want to move it under Allof
> > 
> > if compatiable string (A, B, C...)
> > then
> > 	reg-names:
> > 		-const: dbi
> > 		-const: config
> > 
> > Differece SOC have difference reg-names required list. If split it, it
> > will be easy when add new SOC. Needn't change two place.
> > 
> > Let me update at next version.
> > 
> 
> This patch should be dropped. Why do you remove entries from top-level?
> Are they defined in other schema?

pci/snps,dw-pcie.yaml already define it.

Frank

> 
> Best regards,
> Krzysztof
>