| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 25 Dec 2023 06:26:52 +0800
From: kernel test robot <lkp@...el.com>
To: Keerthy <j-keerthy@...com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
Tony Lindgren <tony@...mide.com>
Subject: drivers/rtc/rtc-omap.c:424: warning: Function parameter or member
'dev' not described in 'omap_rtc_power_off_program'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 861deac3b092f37b2c5e6871732f3e11486f7082
commit: 6256f7f7f217b2216fcb73929508325f4ee98237 rtc: OMAP: Add support for rtc-only mode
date: 4 years, 9 months ago
config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20231225/202312250610.si1QZoLJ-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231225/202312250610.si1QZoLJ-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312250610.si1QZoLJ-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/rtc/rtc-omap.c:424: warning: Function parameter or member 'dev' not described in 'omap_rtc_power_off_program'
vim +424 drivers/rtc/rtc-omap.c
222a12fca60482 Johan Hovold 2014-12-10 417
6256f7f7f217b2 Keerthy 2019-04-03 418 /**
6256f7f7f217b2 Keerthy 2019-04-03 419 * omap_rtc_power_off_program: Set the pmic power off sequence. The RTC
6256f7f7f217b2 Keerthy 2019-04-03 420 * generates pmic_pwr_enable control, which can be used to control an external
6256f7f7f217b2 Keerthy 2019-04-03 421 * PMIC.
222a12fca60482 Johan Hovold 2014-12-10 422 */
6256f7f7f217b2 Keerthy 2019-04-03 423 int omap_rtc_power_off_program(struct device *dev)
222a12fca60482 Johan Hovold 2014-12-10 @424 {
222a12fca60482 Johan Hovold 2014-12-10 425 struct omap_rtc *rtc = omap_rtc_power_off_rtc;
222a12fca60482 Johan Hovold 2014-12-10 426 struct rtc_time tm;
222a12fca60482 Johan Hovold 2014-12-10 427 unsigned long now;
09058eab4b4f77 Keerthy 2018-08-16 428 int seconds;
222a12fca60482 Johan Hovold 2014-12-10 429 u32 val;
222a12fca60482 Johan Hovold 2014-12-10 430
9c28bd07c20776 Lokesh Vutla 2015-04-16 431 rtc->type->unlock(rtc);
222a12fca60482 Johan Hovold 2014-12-10 432 /* enable pmic_power_en control */
222a12fca60482 Johan Hovold 2014-12-10 433 val = rtc_readl(rtc, OMAP_RTC_PMIC_REG);
222a12fca60482 Johan Hovold 2014-12-10 434 rtc_writel(rtc, OMAP_RTC_PMIC_REG, val | OMAP_RTC_PMIC_POWER_EN_EN);
222a12fca60482 Johan Hovold 2014-12-10 435
09058eab4b4f77 Keerthy 2018-08-16 436 again:
6256f7f7f217b2 Keerthy 2019-04-03 437 /* Clear any existing ALARM2 event */
6256f7f7f217b2 Keerthy 2019-04-03 438 rtc_writel(rtc, OMAP_RTC_STATUS_REG, OMAP_RTC_STATUS_ALARM2);
6256f7f7f217b2 Keerthy 2019-04-03 439
09058eab4b4f77 Keerthy 2018-08-16 440 /* set alarm one second from now */
222a12fca60482 Johan Hovold 2014-12-10 441 omap_rtc_read_time_raw(rtc, &tm);
09058eab4b4f77 Keerthy 2018-08-16 442 seconds = tm.tm_sec;
222a12fca60482 Johan Hovold 2014-12-10 443 bcd2tm(&tm);
222a12fca60482 Johan Hovold 2014-12-10 444 rtc_tm_to_time(&tm, &now);
09058eab4b4f77 Keerthy 2018-08-16 445 rtc_time_to_tm(now + 1, &tm);
222a12fca60482 Johan Hovold 2014-12-10 446
222a12fca60482 Johan Hovold 2014-12-10 447 if (tm2bcd(&tm) < 0) {
222a12fca60482 Johan Hovold 2014-12-10 448 dev_err(&rtc->rtc->dev, "power off failed\n");
4425070a5cfe63 Johan Hovold 2018-07-04 449 rtc->type->lock(rtc);
6256f7f7f217b2 Keerthy 2019-04-03 450 return -EINVAL;
222a12fca60482 Johan Hovold 2014-12-10 451 }
222a12fca60482 Johan Hovold 2014-12-10 452
222a12fca60482 Johan Hovold 2014-12-10 453 rtc_wait_not_busy(rtc);
222a12fca60482 Johan Hovold 2014-12-10 454
222a12fca60482 Johan Hovold 2014-12-10 455 rtc_write(rtc, OMAP_RTC_ALARM2_SECONDS_REG, tm.tm_sec);
222a12fca60482 Johan Hovold 2014-12-10 456 rtc_write(rtc, OMAP_RTC_ALARM2_MINUTES_REG, tm.tm_min);
222a12fca60482 Johan Hovold 2014-12-10 457 rtc_write(rtc, OMAP_RTC_ALARM2_HOURS_REG, tm.tm_hour);
222a12fca60482 Johan Hovold 2014-12-10 458 rtc_write(rtc, OMAP_RTC_ALARM2_DAYS_REG, tm.tm_mday);
222a12fca60482 Johan Hovold 2014-12-10 459 rtc_write(rtc, OMAP_RTC_ALARM2_MONTHS_REG, tm.tm_mon);
222a12fca60482 Johan Hovold 2014-12-10 460 rtc_write(rtc, OMAP_RTC_ALARM2_YEARS_REG, tm.tm_year);
222a12fca60482 Johan Hovold 2014-12-10 461
222a12fca60482 Johan Hovold 2014-12-10 462 /*
222a12fca60482 Johan Hovold 2014-12-10 463 * enable ALARM2 interrupt
222a12fca60482 Johan Hovold 2014-12-10 464 *
222a12fca60482 Johan Hovold 2014-12-10 465 * NOTE: this fails on AM3352 if rtc_write (writeb) is used
222a12fca60482 Johan Hovold 2014-12-10 466 */
222a12fca60482 Johan Hovold 2014-12-10 467 val = rtc_read(rtc, OMAP_RTC_INTERRUPTS_REG);
222a12fca60482 Johan Hovold 2014-12-10 468 rtc_writel(rtc, OMAP_RTC_INTERRUPTS_REG,
222a12fca60482 Johan Hovold 2014-12-10 469 val | OMAP_RTC_INTERRUPTS_IT_ALARM2);
09058eab4b4f77 Keerthy 2018-08-16 470
09058eab4b4f77 Keerthy 2018-08-16 471 /* Retry in case roll over happened before alarm was armed. */
09058eab4b4f77 Keerthy 2018-08-16 472 if (rtc_read(rtc, OMAP_RTC_SECONDS_REG) != seconds) {
09058eab4b4f77 Keerthy 2018-08-16 473 val = rtc_read(rtc, OMAP_RTC_STATUS_REG);
09058eab4b4f77 Keerthy 2018-08-16 474 if (!(val & OMAP_RTC_STATUS_ALARM2))
09058eab4b4f77 Keerthy 2018-08-16 475 goto again;
09058eab4b4f77 Keerthy 2018-08-16 476 }
09058eab4b4f77 Keerthy 2018-08-16 477
9c28bd07c20776 Lokesh Vutla 2015-04-16 478 rtc->type->lock(rtc);
222a12fca60482 Johan Hovold 2014-12-10 479
6256f7f7f217b2 Keerthy 2019-04-03 480 return 0;
6256f7f7f217b2 Keerthy 2019-04-03 481 }
6256f7f7f217b2 Keerthy 2019-04-03 482 EXPORT_SYMBOL(omap_rtc_power_off_program);
6256f7f7f217b2 Keerthy 2019-04-03 483
:::::: The code at line 424 was first introduced by commit
:::::: 222a12fca6048249d9007f2a4c5fbcea532e8522 rtc: omap: add support for pmic_power_en
:::::: TO: Johan Hovold <johan@...nel.org>
:::::: CC: Linus Torvalds <torvalds@...ux-foundation.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists