linux-kernel - Re: [PATCH v3 1/5] ASoC: dt-bindings: move tas2563 from tas2562.yaml to tas2781.yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <74711d84-4c43-431e-8e7c-95753f4c8815@linaro.org>
Date: Mon, 25 Dec 2023 14:12:20 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Shenghao Ding <shenghao-ding@...com>, broonie@...nel.org,
 conor+dt@...nel.org
Cc: robh+dt@...nel.org, andriy.shevchenko@...ux.intel.com, kevin-lu@...com,
 baojun.xu@...com, devicetree@...r.kernel.org, lgirdwood@...il.com,
 perex@...ex.cz, pierre-louis.bossart@...ux.intel.com, 13916275206@....com,
 linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
 liam.r.girdwood@...el.com, soyer@....hu, tiwai@...e.de, peeyush@...com,
 navada@...com
Subject: Re: [PATCH v3 1/5] ASoC: dt-bindings: move tas2563 from tas2562.yaml
 to tas2781.yaml

On 25/12/2023 06:39, Shenghao Ding wrote:
> Move tas2563 from tas2562.yaml to tas2781.yaml, because tas2563 only work
> in bypass-DSP mode with tas2562 driver. In oder to enable DSP mode for
> tas2563, it has been moved to tas2781 driver. As to the hardware part,
> such as register setting and DSP firmware, all these are stored in the
> binary firmware. What tas2781 drivder dooes is to parse the firmware and
> download them to the tas2781 or tas2563, then power on tas2781 or tas2563.
> So, tas2781 driver can be resued as tas2563 driver。 Only attention will
> be paid to downloading corresponding firmware.
> 
> Signed-off-by: Shenghao Ding <shenghao-ding@...com>
> 
> ---
> Change in v3:
>  - remove tas2563, which will be move to tas2781 driver
>  - Add more comments on why move tas2563 to tas2781 driver
>  - provide rationale in terms of bindings and hardware, not in terms of driver.
>    Or at least not only.

How did you implement my comment about squashing?

If you decided not to implement it, why not dropping a note?

Best regards,
Krzysztof