| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 25 Dec 2023 14:27:46 +0100 From: Krzysztof Kozlowski <krzk@...nel.org> To: xiazhengqiao <xiazhengqiao@...qin.corp-partner.google.com>, linux-input@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org Cc: dmitry.torokhov@...il.com, robh+dt@...nel.org, jikos@...nel.org, benjamin.tissoires@...hat.com, dianders@...omium.org Subject: Re: [v1 1/2] dt-bindings: HID: i2c-hid: elan: Introduce bindings for Ilitek ili2901 On 25/12/2023 10:28, xiazhengqiao wrote: > Because ilitek, ili2901 needs to use reset to pull down the time for 10ms, > so we need to control the reset, use this drive control. > > Signed-off-by: xiazhengqiao <xiazhengqiao@...qin.corp-partner.google.com> > --- > Documentation/devicetree/bindings/input/elan,ekth6915.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml > index 3e2d216c6432..b9e51432b9e8 100644 > --- a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml > +++ b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml > @@ -20,6 +20,7 @@ properties: > compatible: > items: > - const: elan,ekth6915 > + - const: ilitek,ili2901 1. You are adding fallback which was not explained in commit msg. 2. What's more, this was not tested. Please test your code before sending... 3. Plus you did not Cc maintainers, so I suspect you work on some ancient tree... Best regards, Krzysztof
Powered by blists - more mailing lists