linux-kernel - Re: [PATCH v7] misc: Add Nitro Secure Module driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231225115827-mutt-send-email-mst@kernel.org>
Date: Mon, 25 Dec 2023 12:02:16 -0500
From: "Michael S. Tsirkin" <mst@...hat.com>
To: Alexander Graf <graf@...zon.com>
Cc: linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
	Arnd Bergmann <arnd@...db.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Olivia Mackall <olivia@...enic.com>,
	Petre Eftime <petre.eftime@...il.com>,
	Erdem Meydanlli <meydanli@...zon.nl>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	David Woodhouse <dwmw@...zon.co.uk>,
	Jason Wang <jasowang@...hat.com>,
	Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
	Christophe JAILLET <christophe.jaillet@...adoo.fr>
Subject: Re: [PATCH v7] misc: Add Nitro Secure Module driver

On Mon, Dec 25, 2023 at 05:07:29PM +0100, Alexander Graf wrote:
> Hey Michael,
> 
> On 25.12.23 15:06, Michael S. Tsirkin wrote:
> > On Wed, Oct 11, 2023 at 09:35:22PM +0000, Alexander Graf wrote:
> > > When running Linux inside a Nitro Enclave, the hypervisor provides a
> > > special virtio device called "Nitro Security Module" (NSM). This device
> > > has 3 main functions:
> > > 
> > >    1) Provide attestation reports
> > >    2) Modify PCR state
> > >    3) Provide entropy
> > > 
> > > This patch adds a driver for NSM that exposes a /dev/nsm device node which
> > > user space can issue an ioctl on this device with raw NSM CBOR formatted
> > > commands to request attestation documents, influence PCR states, read
> > > entropy and enumerate status of the device. In addition, the driver
> > > implements a hwrng backend.
> > > 
> > > Originally-by: Petre Eftime <petre.eftime@...il.com>
> > > Signed-off-by: Alexander Graf <graf@...zon.com>
> > Alex are you going to publish the spec patch for this device?  Important
> > so we don't need to guess at behaviour when e.g.  making changes to
> > virtio APIs.  Also, which tree do you want this to go through?
> 
> 
> The spec patch including ping mail are sitting on the virtio-comments
> mailing list since October. I haven't seen any reply unfortunately :(
> 
> https://lore.kernel.org/virtio-comment/20231025235345.17788-1-graf@amazon.com/
> 
> Happy to read feedback if you have any :).

Oh I forgot.
Now that I've read the driver, I actually have some :)
I think there's an assumption that there's a request buffer
and response buffer queued by the driver, and that
the device always first consumes the request buffer
followed by consuming the response buffer.
If that is right then driver is ok but spec needs
clarification, will note on virtio-comment.


> This patch here is already applied in Greg's misc tree which I'm happy to
> have it trickle to Linus through.
> 
> 
> Alex
> 
> 
> 
> 
> Amazon Development Center Germany GmbH
> Krausenstr. 38
> 10117 Berlin
> Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
> Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
> Sitz: Berlin
> Ust-ID: DE 289 237 879
> 
>