linux-kernel - RE: [PATCH 02/15] media: s5p-mfc: drop unused static s5p_mfc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15cf01da37ba$18936ad0$49ba4070$@samsung.com>
Date: Tue, 26 Dec 2023 10:42:15 +0530
From: "Aakarsh Jain" <aakarsh.jain@...sung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@...aro.org>, "'Marek
 Szyprowski'" <m.szyprowski@...sung.com>, "'Andrzej Hajda'"
	<andrzej.hajda@...el.com>, "'Mauro Carvalho Chehab'" <mchehab@...nel.org>
Cc: <linux-fsd@...la.coma>, <linux-samsung-soc@...r.kernel.org>, "'Smitha T
 Murthy'" <smithatmurthy@...il.com>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-media@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 02/15] media: s5p-mfc: drop unused static s5p_mfc_ops



> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: 24 December 2023 21:14
> To: Marek Szyprowski <m.szyprowski@...sung.com>; Andrzej Hajda
> <andrzej.hajda@...el.com>; Mauro Carvalho Chehab
> <mchehab@...nel.org>
> Cc: Aakarsh Jain <aakarsh.jain@...sung.com>; linux-fsd@...la.coma; linux-
> samsung-soc@...r.kernel.org; Smitha T Murthy
> <smithatmurthy@...il.com>; linux-arm-kernel@...ts.infradead.org; linux-
> media@...r.kernel.org; linux-kernel@...r.kernel.org; Krzysztof Kozlowski
> <krzysztof.kozlowski@...aro.org>
> Subject: [PATCH 02/15] media: s5p-mfc: drop unused static s5p_mfc_ops
> 
> File-scope static variable "s5p_mfc_ops" is not read after assignment, thus it
> can be dropped entirely.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>  drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c
> b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c
> index 673962301173..5ba791fa3676 100644
> --- a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c
> +++ b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c
> @@ -14,18 +14,15 @@
>  #include "s5p_mfc_opr_v5.h"
>  #include "s5p_mfc_opr_v6.h"
> 
> -static struct s5p_mfc_hw_ops *s5p_mfc_ops;
> -
>  void s5p_mfc_init_hw_ops(struct s5p_mfc_dev *dev)  {
>  	if (IS_MFCV6_PLUS(dev)) {
> -		s5p_mfc_ops = s5p_mfc_init_hw_ops_v6();
> +		dev->mfc_ops = s5p_mfc_init_hw_ops_v6();
>  		dev->warn_start = S5P_FIMV_ERR_WARNINGS_START_V6;
>  	} else {
> -		s5p_mfc_ops = s5p_mfc_init_hw_ops_v5();
> +		dev->mfc_ops = s5p_mfc_init_hw_ops_v5();
>  		dev->warn_start = S5P_FIMV_ERR_WARNINGS_START;
>  	}
> -	dev->mfc_ops = s5p_mfc_ops;
>  }
> 
>  void s5p_mfc_init_regs(struct s5p_mfc_dev *dev)
> 
> --
> 2.34.1

Reviewed-by: Aakarsh Jain <aakarsh.jain@...sung.com>

Thanks!